PL/pgSQL RETURN NEXT was leaking converted tuples, causing

jconway · jconway · commit b58bacdacbb1 · 2012-05-09T22:57:19.000-07:00
out of memory when looping through large numbers of rows.
Flag the converted tuples to be freed. Complaint and patch
by Joe.
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -2472,6 +2472,7 @@ exec_stmt_return_next(PLpgSQL_execstate *estate,
 					{
 						tuple = do_convert_tuple(tuple, tupmap);
 						free_conversion_map(tupmap);
+						free_tuple = true;
 					}
 				}
 				break;

Original file line number	Diff line number	Diff line change
`@@ -2472,6 +2472,7 @@ exec_stmt_return_next(PLpgSQL_execstate *estate,`
`2472`	`2472`	`{`
`2473`	`2473`	`tuple = do_convert_tuple(tuple, tupmap);`
`2474`	`2474`	`free_conversion_map(tupmap);`
	`2475`	`+ free_tuple = true;`
`2475`	`2476`	`}`
`2476`	`2477`	`}`
`2477`	`2478`	`break;`