Silence benign warnings from clang version 3.0-6ubuntu3.

kgrittn · kgrittn · commit b64b5ccb6a9c · 2013-11-07T16:35:43.000-06:00
diff --git a/contrib/pg_standby/pg_standby.c b/contrib/pg_standby/pg_standby.c
@@ -345,7 +345,7 @@ SetWALFileNameForCleanup(void)
 	if (keepfiles > 0)
 	{
 		sscanf(nextWALFileName, "%08X%08X%08X", &tli, &log, &seg);
-		if (tli > 0 && log >= 0 && seg > 0)
+		if (tli > 0 && seg > 0)
 		{
 			log_diff = keepfiles / MaxSegmentsPerLogFile;
 			seg_diff = keepfiles % MaxSegmentsPerLogFile;
diff --git a/src/backend/utils/cache/catcache.c b/src/backend/utils/cache/catcache.c
@@ -566,8 +566,9 @@ AtEOXact_CatCache(bool isCommit)
 			/* Check CatCLists */
 			dlist_foreach(iter, &ccp->cc_lists)
 			{
-				CatCList   *cl = dlist_container(CatCList, cache_elem, iter.cur);
+				CatCList   *cl;
 
+				cl = dlist_container(CatCList, cache_elem, iter.cur);
 				Assert(cl->cl_magic == CL_MAGIC);
 				Assert(cl->refcount == 0);
 				Assert(!cl->dead);
@@ -580,8 +581,9 @@ AtEOXact_CatCache(bool isCommit)
 
 				dlist_foreach(iter, bucket)
 				{
-					CatCTup    *ct = dlist_container(CatCTup, cache_elem, iter.cur);
+					CatCTup    *ct;
 
+					ct = dlist_container(CatCTup, cache_elem, iter.cur);
 					Assert(ct->ct_magic == CT_MAGIC);
 					Assert(ct->refcount == 0);
 					Assert(!ct->dead);

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ SetWALFileNameForCleanup(void)`
`345`	`345`	`if (keepfiles > 0)`
`346`	`346`	`{`
`347`	`347`	`sscanf(nextWALFileName, "%08X%08X%08X", &tli, &log, &seg);`
`348`		`- if (tli > 0 && log >= 0 && seg > 0)`
	`348`	`+ if (tli > 0 && seg > 0)`
`349`	`349`	`{`
`350`	`350`	`log_diff = keepfiles / MaxSegmentsPerLogFile;`
`351`	`351`	`seg_diff = keepfiles % MaxSegmentsPerLogFile;`