Log send() failures when sending to statistics process (but only in

tglsfdc · tglsfdc · commit b740be2520f2 · 2005-08-30T02:47:37.000Z
assert-enabled builds).  This is a temporary measure to see if we can
learn anything about those intermittent stats test failures in the
buildfarm.
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
@@ -13,7 +13,7 @@
  *
  *	Copyright (c) 2001-2005, PostgreSQL Global Development Group
  *
- *	$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.106 2005/08/15 16:25:17 tgl Exp $
+ *	$PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.107 2005/08/30 02:47:37 tgl Exp $
  * ----------
  */
 #include "postgres.h"
@@ -1446,8 +1446,13 @@ pgstat_send(void *msg, int len)
 
 	((PgStat_MsgHdr *) msg)->m_size = len;
 
+#ifdef USE_ASSERT_CHECKING
+	if (send(pgStatSock, msg, len, 0) < 0)
+		elog(LOG, "could not send to statistics collector: %m");
+#else
 	send(pgStatSock, msg, len, 0);
 	/* We deliberately ignore any error from send() */
+#endif
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`* Copyright (c) 2001-2005, PostgreSQL Global Development Group`
`15`	`15`	`*`
`16`		`- * $PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.106 2005/08/15 16:25:17 tgl Exp $`
	`16`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/pgstat.c,v 1.107 2005/08/30 02:47:37 tgl Exp $`
`17`	`17`	`* ----------`
`18`	`18`	`*/`
`19`	`19`	`#include "postgres.h"`
`@@ -1446,8 +1446,13 @@ pgstat_send(void *msg, int len)`
`1446`	`1446`
`1447`	`1447`	`((PgStat_MsgHdr *) msg)->m_size = len;`
`1448`	`1448`
	`1449`	`+#ifdef USE_ASSERT_CHECKING`
	`1450`	`+ if (send(pgStatSock, msg, len, 0) < 0)`
	`1451`	`+ elog(LOG, "could not send to statistics collector: %m");`
	`1452`	`+#else`
`1449`	`1453`	`send(pgStatSock, msg, len, 0);`
`1450`	`1454`	`/* We deliberately ignore any error from send() */`
	`1455`	`+#endif`
`1451`	`1456`	`}`
`1452`	`1457`
`1453`	`1458`