> (I also see some post-7.4.1 changes in src/template/solaris, so you

bmomjian · bmomjian · commit b76c536e2e7e · 2004-03-14T14:01:43.000Z
&gt; possibly should look there too.)
[snip]
&gt;

I think I have the fix for part of it, but this remains...

    gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes
    -Wmissing-declarations -fPIC -I. -I../../../src/include
    -D_POSIX_PTHREAD_SEMANTICS -DFRONTEND
    -DSYSCONFDIR='"/usr/local/pgsql/etc"'  -c -o thread.o thread.c
    thread.c: In function `pqGethostbyname':
    thread.c:189: error: `resbuf' undeclared (first use in this
function)

Looking at src/port/thread.c, line 189, it looks like somebody typo'd.
Looks like that second parameter should be "resultbuf", not "resbuf"?

Jim Seymour
diff --git a/src/port/thread.c b/src/port/thread.c
@@ -7,7 +7,7 @@
  *
  * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/port/thread.c,v 1.16 2004/03/02 18:35:59 momjian Exp $
+ * $PostgreSQL: pgsql/src/port/thread.c,v 1.17 2004/03/14 14:01:43 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -137,7 +137,7 @@ pqGethostbyname(const char *name,
 	 * broken (well early POSIX draft) gethostbyname_r() which returns
 	 * 'struct hostent *'
 	 */
-	*result = gethostbyname_r(name, resbuf, buffer, buflen, herrno);
+	*result = gethostbyname_r(name, resultbuf, buffer, buflen, herrno);
 	return (*result == NULL) ? -1 : 0;
 
 #else

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`* Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/port/thread.c,v 1.16 2004/03/02 18:35:59 momjian Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/port/thread.c,v 1.17 2004/03/14 14:01:43 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -137,7 +137,7 @@ pqGethostbyname(const char *name,`
`137`	`137`	`* broken (well early POSIX draft) gethostbyname_r() which returns`
`138`	`138`	`* 'struct hostent *'`
`139`	`139`	`*/`
`140`		`- *result = gethostbyname_r(name, resbuf, buffer, buflen, herrno);`
	`140`	`+ *result = gethostbyname_r(name, resultbuf, buffer, buflen, herrno);`
`141`	`141`	`return (*result == NULL) ? -1 : 0;`
`142`	`142`
`143`	`143`	`#else`