xcopy can only deal with forward-slashed paths when it's quoted - needed

mhagander · mhagander · commit b7d3a8453921 · 2007-04-02T12:11:26.000Z
for "vcregress check" to work.
Per report from Dave Page.
diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
@@ -3,7 +3,7 @@ package Install;
 #
 # Package that provides 'make install' functionality for msvc builds
 #
-# $PostgreSQL: pgsql/src/tools/msvc/Install.pm,v 1.6 2007/03/29 20:48:26 mha Exp $
+# $PostgreSQL: pgsql/src/tools/msvc/Install.pm,v 1.7 2007/04/02 12:11:26 mha Exp $
 #
 use strict;
 use warnings;
@@ -67,6 +67,8 @@ sub Install
     CopyIncludeFiles($target);
 
     GenerateNLSFiles($target,$config->{nls}) if ($config->{nls});
+
+    print "Installation complete.\n";
 }
 
 sub EnsureDirectories
@@ -336,7 +338,7 @@ sub CopyIncludeFiles
 
         EnsureDirectories($target . '/include/postgresql/server', $d);
         system(
-            "xcopy /s /i /q /r /y src\\include\\$d\\*.h $target\\include\\postgresql\\server\\$d\\")
+            "xcopy /s /i /q /r /y src\\include\\$d\\*.h \"$target\\include\\postgresql\\server\\$d\\\"")
           && croak("Failed to copy include directory $d\n");
     }
     closedir($D);

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ package Install;`
`3`	`3`	`#`
`4`	`4`	`# Package that provides 'make install' functionality for msvc builds`
`5`	`5`	`#`
`6`		`-# $PostgreSQL: pgsql/src/tools/msvc/Install.pm,v 1.6 2007/03/29 20:48:26 mha Exp $`
	`6`	`+# $PostgreSQL: pgsql/src/tools/msvc/Install.pm,v 1.7 2007/04/02 12:11:26 mha Exp $`
`7`	`7`	`#`
`8`	`8`	`use strict;`
`9`	`9`	`use warnings;`
`@@ -67,6 +67,8 @@ sub Install`
`67`	`67`	`CopyIncludeFiles($target);`
`68`	`68`
`69`	`69`	`GenerateNLSFiles($target,$config->{nls}) if ($config->{nls});`
	`70`	`+`
	`71`	`+ print "Installation complete.\n";`
`70`	`72`	`}`
`71`	`73`
`72`	`74`	`sub EnsureDirectories`
`@@ -336,7 +338,7 @@ sub CopyIncludeFiles`
`336`	`338`
`337`	`339`	`EnsureDirectories($target . '/include/postgresql/server', $d);`
`338`	`340`	`system(`
`339`		`- "xcopy /s /i /q /r /y src\\include\\$d\\*.h $target\\include\\postgresql\\server\\$d\\")`
	`341`	`+ "xcopy /s /i /q /r /y src\\include\\$d\\*.h \"$target\\include\\postgresql\\server\\$d\\\"")`
`340`	`342`	`&& croak("Failed to copy include directory $d\n");`
`341`	`343`	`}`
`342`	`344`	`closedir($D);`