This patch will avoid SIGFPE on some geo functions , if PostgreSQL is compiled

bmomjian · bmomjian · commit bb50fb517f9f · 1999-12-21T17:01:44.000Z
with DEC C.

DEC C doesn't handle double values greater than DBL_MAX, but some
PostgreSQL geo functions assign greater than DBL_MAX values to some vars
in some special cases - that couses SIGFPE. I dunno if that is the only place
to fix to work well with DEC C.

Kirill Nosov.
diff --git a/src/backend/utils/adt/geo_ops.c b/src/backend/utils/adt/geo_ops.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/geo_ops.c,v 1.45 1999/07/17 20:17:56 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/geo_ops.c,v 1.46 1999/12/21 17:01:44 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -876,7 +876,10 @@ line_construct_pm(Point *pt, double m)
 	/* use "mx - y + yinter = 0" */
 	result->A = m;
 	result->B = -1.0;
-	result->C = pt->y - m * pt->x;
+	if (m==DBL_MAX) 
+		result->C = pt->y;
+	else
+		result->C = pt->y - m * pt->x;
 
 #ifdef NOT_USED
 	result->m = m;

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/geo_ops.c,v 1.45 1999/07/17 20:17:56 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/geo_ops.c,v 1.46 1999/12/21 17:01:44 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -876,7 +876,10 @@ line_construct_pm(Point *pt, double m)`
`876`	`876`	`/* use "mx - y + yinter = 0" */`
`877`	`877`	`result->A = m;`
`878`	`878`	`result->B = -1.0;`
`879`		`- result->C = pt->y - m * pt->x;`
	`879`	`+ if (m==DBL_MAX)`
	`880`	`+ result->C = pt->y;`
	`881`	`+ else`
	`882`	`+ result->C = pt->y - m * pt->x;`
`880`	`883`
`881`	`884`	`#ifdef NOT_USED`
`882`	`885`	`result->m = m;`