Fix assorted memory leaks.

tglsfdc · tglsfdc · commit bcc87b6b00de · 2015-07-12T16:26:08.000-04:00
Per Coverity (not that any of these are so non-obvious that they should not
have been caught before commit).  The extent of leakage is probably minor
to unnoticeable, but a leak is a leak.  Back-patch as necessary.

Michael Paquier
diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c
@@ -414,6 +414,7 @@ DropReplicationSlot(PGconn *conn, const char *slot_name)
 		return false;
 	}
 
+	destroyPQExpBuffer(query);
 	PQclear(res);
 	return true;
 }
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -6660,6 +6660,7 @@ getTransforms(Archive *fout, int *numTransforms)
 			appendPQExpBuffer(&namebuf, "%s %s",
 							  typeInfo->dobj.name, lanname);
 		transforminfo[i].dobj.name = namebuf.data;
+		free(lanname);
 	}
 
 	PQclear(res);
@@ -15735,6 +15736,7 @@ getExtensionMembership(Archive *fout, DumpOptions *dopt, ExtensionInfo extinfo[]
 		addObjectDependency(&contable->dataObj->dobj,
 							reftable->dataObj->dobj.dumpId);
 	}
+	PQclear(res);
 	destroyPQExpBuffer(query);
 }
 
diff --git a/src/bin/pg_rewind/libpq_fetch.c b/src/bin/pg_rewind/libpq_fetch.c
@@ -69,7 +69,7 @@ libpqConnect(const char *connstr)
 	pg_free(str);
 
 	/*
-	 * Also check that full_page_writes is enabled. We can get torn pages if
+	 * Also check that full_page_writes is enabled.  We can get torn pages if
 	 * a page is modified while we read it with pg_read_binary_file(), and we
 	 * rely on full page images to fix them.
 	 */
@@ -81,6 +81,7 @@ libpqConnect(const char *connstr)
 
 /*
  * Runs a query that returns a single value.
+ * The result should be pg_free'd after use.
  */
 static char *
 run_simple_query(const char *sql)
@@ -123,6 +124,8 @@ libpqGetCurrentXlogInsertLocation(void)
 
 	result = ((uint64) hi) << 32 | lo;
 
+	pg_free(val);
+
 	return result;
 }
 
@@ -201,6 +204,7 @@ libpqProcessFileList(void)
 
 		process_source_file(path, type, filesize, link_target);
 	}
+	PQclear(res);
 }
 
 /*----
@@ -296,7 +300,7 @@ receiveFileChunks(const char *sql)
 		if (PQgetisnull(res, 0, 2))
 		{
 			pg_log(PG_DEBUG,
-				   "received NULL chunk for file \"%s\", file has been deleted\n",
+			  "received NULL chunk for file \"%s\", file has been deleted\n",
 				   filename);
 			pg_free(filename);
 			PQclear(res);
diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
@@ -393,9 +393,9 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
 		for (i = 0; i < ntups; i++)
 		{
 			appendPQExpBufferStr(&buf,
-							  fmtQualifiedId(PQserverVersion(conn),
-											 PQgetvalue(res, i, 1),
-											 PQgetvalue(res, i, 0)));
+								 fmtQualifiedId(PQserverVersion(conn),
+												PQgetvalue(res, i, 1),
+												PQgetvalue(res, i, 0)));
 
 			simple_string_list_append(&dbtables, buf.data);
 			resetPQExpBuffer(&buf);
@@ -412,6 +412,7 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
 			concurrentCons = ntups;
 		if (concurrentCons <= 1)
 			parallel = false;
+		PQclear(res);
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -414,6 +414,7 @@ DropReplicationSlot(PGconn conn, const char slot_name)`
`414`	`414`	`return false;`
`415`	`415`	`}`
`416`	`416`
	`417`	`+ destroyPQExpBuffer(query);`
`417`	`418`	`PQclear(res);`
`418`	`419`	`return true;`
`419`	`420`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6660,6 +6660,7 @@ getTransforms(Archive fout, int numTransforms)`
`6660`	`6660`	`appendPQExpBuffer(&namebuf, "%s %s",`
`6661`	`6661`	`typeInfo->dobj.name, lanname);`
`6662`	`6662`	`transforminfo[i].dobj.name = namebuf.data;`
	`6663`	`+ free(lanname);`
`6663`	`6664`	`}`
`6664`	`6665`
`6665`	`6666`	`PQclear(res);`
`@@ -15735,6 +15736,7 @@ getExtensionMembership(Archive fout, DumpOptions dopt, ExtensionInfo extinfo[]`
`15735`	`15736`	`addObjectDependency(&contable->dataObj->dobj,`
`15736`	`15737`	`reftable->dataObj->dobj.dumpId);`
`15737`	`15738`	`}`
	`15739`	`+ PQclear(res);`
`15738`	`15740`	`destroyPQExpBuffer(query);`
`15739`	`15741`	`}`
`15740`	`15742`