Fix bogus range_table_mutator() logic for RangeTblEntry.tablesample.

tglsfdc · tglsfdc · commit be87143fe90a · 2015-06-19T11:41:56.000-04:00
Must make a copy of the TableSampleClause node; the previous coding
modified the input data structure in-place.

Petr Jelinek
diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
@@ -2870,10 +2870,14 @@ range_table_mutator(List *rtable,
 			case RTE_RELATION:
 				if (rte->tablesample)
 				{
-					MUTATE(rte->tablesample->args, rte->tablesample->args,
+					CHECKFLATCOPY(newrte->tablesample, rte->tablesample,
+								  TableSampleClause);
+					MUTATE(newrte->tablesample->args,
+						   newrte->tablesample->args,
 						   List *);
-					MUTATE(rte->tablesample->repeatable,
-						   rte->tablesample->repeatable, Node *);
+					MUTATE(newrte->tablesample->repeatable,
+						   newrte->tablesample->repeatable,
+						   Node *);
 				}
 				break;
 			case RTE_CTE:
