Fix vacuum_cost_delay check for balance calculation.

danielgustafsson · danielgustafsson · commit bfac8f8bc4a4 · 2023-04-25T13:54:10.000+02:00
Commit 1021bd6 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to check for greater than or zero. Backpatch to all supported branches since 1021bd6 was backpatched all the way at the time. Author: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/CAD21AoBS7o6Ljt_vfqPQPf67AhzKu3fR0iqk8B=vVYczMugKMQ@mail.gmail.com Backpatch-through: v11 (all supported branches)
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
@@ -2947,7 +2947,7 @@ table_recheck_autovac(Oid relid, HTAB *table_toast_map,
 		 */
 		tab->at_dobalance =
 			!(avopts && (avopts->vacuum_cost_limit > 0 ||
-						 avopts->vacuum_cost_delay > 0));
+						 avopts->vacuum_cost_delay >= 0));
 	}
 
 	heap_freetuple(classTup);

Original file line number	Diff line number	Diff line change
`@@ -2947,7 +2947,7 @@ table_recheck_autovac(Oid relid, HTAB *table_toast_map,`
`2947`	`2947`	`*/`
`2948`	`2948`	`tab->at_dobalance =`
`2949`	`2949`	`!(avopts && (avopts->vacuum_cost_limit > 0 \|\|`
`2950`		`- avopts->vacuum_cost_delay > 0));`
	`2950`	`+ avopts->vacuum_cost_delay >= 0));`
`2951`	`2951`	`}`
`2952`	`2952`
`2953`	`2953`	`heap_freetuple(classTup);`