Applied patch for jdbc from Kim Ho at RedHat to more correctly deal with boolean values

Barry Lind · Barry Lind · commit c020d67bc692 · 2003-09-17T07:00:24.000Z
Modified Files:
 	jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
diff --git a/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java b/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
@@ -9,7 +9,7 @@
  * Copyright (c) 2003, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/jdbc1/Attic/AbstractJdbc1ResultSet.java,v 1.18 2003/09/13 04:02:15 barry Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/jdbc1/Attic/AbstractJdbc1ResultSet.java,v 1.19 2003/09/17 07:00:24 barry Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -797,8 +797,8 @@ public static boolean toBoolean(String s)
 	{
 		if (s != null)
 		{
-			int c = s.charAt(0);
-			return ((c == 't') || (c == 'T') || (c == '1'));
+			s = s.trim();
+			return (s.equalsIgnoreCase("true") || s.equals("1") || s.equalsIgnoreCase("t"));
 		}
 		return false;		// SQL NULL
 	}

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`* Copyright (c) 2003, PostgreSQL Global Development Group`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $Header: /cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/jdbc1/Attic/AbstractJdbc1ResultSet.java,v 1.18 2003/09/13 04:02:15 barry Exp $`
	`12`	`+ * $Header: /cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/jdbc1/Attic/AbstractJdbc1ResultSet.java,v 1.19 2003/09/17 07:00:24 barry Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -797,8 +797,8 @@ public static boolean toBoolean(String s)`
`797`	`797`	`{`
`798`	`798`	`if (s != null)`
`799`	`799`	`{`
`800`		`- int c = s.charAt(0);`
`801`		`- return ((c == 't') \|\| (c == 'T') \|\| (c == '1'));`
	`800`	`+ s = s.trim();`
	`801`	`+ return (s.equalsIgnoreCase("true") \|\| s.equals("1") \|\| s.equalsIgnoreCase("t"));`
`802`	`802`	`}`
`803`	`803`	`return false; // SQL NULL`
`804`	`804`	`}`