Remove dead code in pg_dump.

tglsfdc · tglsfdc · commit c08521eb5513 · 2016-10-13T16:08:16.000-04:00
I'm not sure if this provision for "pg_backup" behaving a bit differently
from "pg_dump" ever did anything useful in a released version.  But it's
definitely dead code now.

Michael Paquier
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -363,10 +363,6 @@ main(int argc, char **argv)
 
 	progname = get_progname(argv[0]);
 
-	/* Set default options based on progname */
-	if (strcmp(progname, "pg_backup") == 0)
-		format = "c";
-
 	if (argc > 1)
 	{
 		if (strcmp(argv[1], "--help") == 0 || strcmp(argv[1], "-?") == 0)

Original file line number	Diff line number	Diff line change
`@@ -363,10 +363,6 @@ main(int argc, char **argv)`
`363`	`363`
`364`	`364`	`progname = get_progname(argv[0]);`
`365`	`365`
`366`		`- /* Set default options based on progname */`
`367`		`- if (strcmp(progname, "pg_backup") == 0)`
`368`		`- format = "c";`
`369`		`-`
`370`	`366`	`if (argc > 1)`
`371`	`367`	`{`
`372`	`368`	`if (strcmp(argv[1], "--help") == 0 \|\| strcmp(argv[1], "-?") == 0)`