Use just NULL not NULL::TEXT --- the latter coding is unnecessary and

tglsfdc · tglsfdc · commit c14f2ba7a486 · 2005-06-07T14:04:48.000Z
not schema-safe.  Per report from Jochem van Dieten.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.408 2005/04/30 08:08:51 neilc Exp $
+ *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.409 2005/06/07 14:04:48 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5189,8 +5189,8 @@ dumpFunc(Archive *fout, FuncInfo *finfo)
 	{
 		appendPQExpBuffer(query,
 						  "SELECT proretset, prosrc, probin, "
-						  "null::text as proallargtypes, "
-						  "null::text as proargmodes, "
+						  "null as proallargtypes, "
+						  "null as proargmodes, "
 						  "proargnames, "
 						  "provolatile, proisstrict, prosecdef, "
 						  "(SELECT lanname FROM pg_catalog.pg_language WHERE oid = prolang) as lanname "
@@ -5202,9 +5202,9 @@ dumpFunc(Archive *fout, FuncInfo *finfo)
 	{
 		appendPQExpBuffer(query,
 						  "SELECT proretset, prosrc, probin, "
-						  "null::text as proallargtypes, "
-						  "null::text as proargmodes, "
-						  "null::text as proargnames, "
+						  "null as proallargtypes, "
+						  "null as proargmodes, "
+						  "null as proargnames, "
 						  "provolatile, proisstrict, prosecdef, "
 						  "(SELECT lanname FROM pg_catalog.pg_language WHERE oid = prolang) as lanname "
 						  "FROM pg_catalog.pg_proc "
@@ -5215,9 +5215,9 @@ dumpFunc(Archive *fout, FuncInfo *finfo)
 	{
 		appendPQExpBuffer(query,
 						  "SELECT proretset, prosrc, probin, "
-						  "null::text as proallargtypes, "
-						  "null::text as proargmodes, "
-						  "null::text as proargnames, "
+						  "null as proallargtypes, "
+						  "null as proargmodes, "
+						  "null as proargnames, "
 		 "case when proiscachable then 'i' else 'v' end as provolatile, "
 						  "proisstrict, "
 						  "'f'::boolean as prosecdef, "
@@ -5230,9 +5230,9 @@ dumpFunc(Archive *fout, FuncInfo *finfo)
 	{
 		appendPQExpBuffer(query,
 						  "SELECT proretset, prosrc, probin, "
-						  "null::text as proallargtypes, "
-						  "null::text as proargmodes, "
-						  "null::text as proargnames, "
+						  "null as proallargtypes, "
+						  "null as proargmodes, "
+						  "null as proargnames, "
 		 "case when proiscachable then 'i' else 'v' end as provolatile, "
 						  "'f'::boolean as proisstrict, "
 						  "'f'::boolean as prosecdef, "
