Update and improve comments.

robertmhaas · robertmhaas · commit c161ea138fe1 · 2018-02-28T10:09:31.000-05:00
Commits 6f6b99d and f3b0897 didn't properly update these comments. Etsuro Fujita, reviewed by Amit Langote Discussion: http://postgr.es/m/5A671FE1.6020305@lab.ntt.co.jp
diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
@@ -1725,14 +1725,11 @@ make_partition_op_expr(PartitionKey key, int keynum,
 /*
  * get_qual_for_hash
  *
- * Given a list of partition columns, modulus and remainder corresponding to a
- * partition, this function returns CHECK constraint expression Node for that
- * partition.
+ * Returns a CHECK constraint expression to use as a hash partition's
+ * constraint, given the parent relation and partition bound structure.
  *
  * The partition constraint for a hash partition is always a call to the
- * built-in function satisfies_hash_partition().  The first two arguments are
- * the modulus and remainder for the partition; the remaining arguments are the
- * values to be hashed.
+ * built-in function satisfies_hash_partition().
  */
 static List *
 get_qual_for_hash(Relation parent, PartitionBoundSpec *spec)
@@ -1812,7 +1809,7 @@ get_qual_for_hash(Relation parent, PartitionBoundSpec *spec)
  * get_qual_for_list
  *
  * Returns an implicit-AND list of expressions to use as a list partition's
- * constraint, given the partition key and bound structures.
+ * constraint, given the parent relation and partition bound structure.
  *
  * The function returns NIL for a default partition when it's the only
  * partition since in that case there is no constraint.
@@ -2086,7 +2083,7 @@ get_range_nulltest(PartitionKey key)
  * get_qual_for_range
  *
  * Returns an implicit-AND list of expressions to use as a range partition's
- * constraint, given the partition key and bound structures.
+ * constraint, given the parent relation and partition bound structure.
  *
  * For a multi-column range partition key, say (a, b, c), with (al, bl, cl)
  * as the lower bound tuple and (au, bu, cu) as the upper bound tuple, we

Original file line number	Diff line number	Diff line change
`@@ -1725,14 +1725,11 @@ make_partition_op_expr(PartitionKey key, int keynum,`
`1725`	`1725`	`/*`
`1726`	`1726`	`* get_qual_for_hash`
`1727`	`1727`	`*`
`1728`		`- * Given a list of partition columns, modulus and remainder corresponding to a`
`1729`		`- * partition, this function returns CHECK constraint expression Node for that`
`1730`		`- * partition.`
	`1728`	`+ * Returns a CHECK constraint expression to use as a hash partition's`
	`1729`	`+ * constraint, given the parent relation and partition bound structure.`
`1731`	`1730`	`*`
`1732`	`1731`	`* The partition constraint for a hash partition is always a call to the`
`1733`		`- * built-in function satisfies_hash_partition(). The first two arguments are`
`1734`		`- * the modulus and remainder for the partition; the remaining arguments are the`
`1735`		`- * values to be hashed.`
	`1732`	`+ * built-in function satisfies_hash_partition().`
`1736`	`1733`	`*/`
`1737`	`1734`	`static List *`
`1738`	`1735`	`get_qual_for_hash(Relation parent, PartitionBoundSpec *spec)`
`@@ -1812,7 +1809,7 @@ get_qual_for_hash(Relation parent, PartitionBoundSpec *spec)`
`1812`	`1809`	`* get_qual_for_list`
`1813`	`1810`	`*`
`1814`	`1811`	`* Returns an implicit-AND list of expressions to use as a list partition's`
`1815`		`- * constraint, given the partition key and bound structures.`
	`1812`	`+ * constraint, given the parent relation and partition bound structure.`
`1816`	`1813`	`*`
`1817`	`1814`	`* The function returns NIL for a default partition when it's the only`
`1818`	`1815`	`* partition since in that case there is no constraint.`
`@@ -2086,7 +2083,7 @@ get_range_nulltest(PartitionKey key)`
`2086`	`2083`	`* get_qual_for_range`
`2087`	`2084`	`*`
`2088`	`2085`	`* Returns an implicit-AND list of expressions to use as a range partition's`
`2089`		`- * constraint, given the partition key and bound structures.`
	`2086`	`+ * constraint, given the parent relation and partition bound structure.`
`2090`	`2087`	`*`
`2091`	`2088`	`* For a multi-column range partition key, say (a, b, c), with (al, bl, cl)`
`2092`	`2089`	`* as the lower bound tuple and (au, bu, cu) as the upper bound tuple, we`