Fix minor signed/unsigned mixup

petere · petere · commit c209d317e9b8 · 2023-04-05T07:34:52.000+02:00
The chunk header is unsigned, and the output format takes unsigned, so
casting it to signed in between is incorrect.
diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c
@@ -217,30 +217,30 @@ static void
 BogusFree(void *pointer)
 {
 	elog(ERROR, "pfree called with invalid pointer %p (header 0x%016llx)",
-		 pointer, (long long) GetMemoryChunkHeader(pointer));
+		 pointer, (unsigned long long) GetMemoryChunkHeader(pointer));
 }
 
 static void *
 BogusRealloc(void *pointer, Size size)
 {
 	elog(ERROR, "repalloc called with invalid pointer %p (header 0x%016llx)",
-		 pointer, (long long) GetMemoryChunkHeader(pointer));
+		 pointer, (unsigned long long) GetMemoryChunkHeader(pointer));
 	return NULL;				/* keep compiler quiet */
 }
 
 static MemoryContext
 BogusGetChunkContext(void *pointer)
 {
 	elog(ERROR, "GetMemoryChunkContext called with invalid pointer %p (header 0x%016llx)",
-		 pointer, (long long) GetMemoryChunkHeader(pointer));
+		 pointer, (unsigned long long) GetMemoryChunkHeader(pointer));
 	return NULL;				/* keep compiler quiet */
 }
 
 static Size
 BogusGetChunkSpace(void *pointer)
 {
 	elog(ERROR, "GetMemoryChunkSpace called with invalid pointer %p (header 0x%016llx)",
-		 pointer, (long long) GetMemoryChunkHeader(pointer));
+		 pointer, (unsigned long long) GetMemoryChunkHeader(pointer));
 	return 0;					/* keep compiler quiet */
 }
 

Original file line number	Diff line number	Diff line change
`@@ -217,30 +217,30 @@ static void`
`217`	`217`	`BogusFree(void *pointer)`
`218`	`218`	`{`
`219`	`219`	`elog(ERROR, "pfree called with invalid pointer %p (header 0x%016llx)",`
`220`		`- pointer, (long long) GetMemoryChunkHeader(pointer));`
	`220`	`+ pointer, (unsigned long long) GetMemoryChunkHeader(pointer));`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`static void *`
`224`	`224`	`BogusRealloc(void *pointer, Size size)`
`225`	`225`	`{`
`226`	`226`	`elog(ERROR, "repalloc called with invalid pointer %p (header 0x%016llx)",`
`227`		`- pointer, (long long) GetMemoryChunkHeader(pointer));`
	`227`	`+ pointer, (unsigned long long) GetMemoryChunkHeader(pointer));`
`228`	`228`	`return NULL; /* keep compiler quiet */`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`static MemoryContext`
`232`	`232`	`BogusGetChunkContext(void *pointer)`
`233`	`233`	`{`
`234`	`234`	`elog(ERROR, "GetMemoryChunkContext called with invalid pointer %p (header 0x%016llx)",`
`235`		`- pointer, (long long) GetMemoryChunkHeader(pointer));`
	`235`	`+ pointer, (unsigned long long) GetMemoryChunkHeader(pointer));`
`236`	`236`	`return NULL; /* keep compiler quiet */`
`237`	`237`	`}`
`238`	`238`
`239`	`239`	`static Size`
`240`	`240`	`BogusGetChunkSpace(void *pointer)`
`241`	`241`	`{`
`242`	`242`	`elog(ERROR, "GetMemoryChunkSpace called with invalid pointer %p (header 0x%016llx)",`
`243`		`- pointer, (long long) GetMemoryChunkHeader(pointer));`
	`243`	`+ pointer, (unsigned long long) GetMemoryChunkHeader(pointer));`
`244`	`244`	`return 0; /* keep compiler quiet */`
`245`	`245`	`}`
`246`	`246`