Fix minor memory leak introduced in recent SQL-functions hacking: the

tglsfdc · tglsfdc · commit c2138f3caad7 · 2008-11-27T00:10:04.000Z
DestReceiver created during postquel_start needs to be destroyed during
postquel_end.  In a moment of brain fade I had assumed this would be taken
care of by FreeQueryDesc, but it's not (and shouldn't be).
diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.128 2008/10/31 21:07:55 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.129 2008/11/27 00:10:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -501,6 +501,8 @@ postquel_end(execution_state *es)
 		PopActiveSnapshot();
 	}
 
+	(*es->qd->dest->rDestroy) (es->qd->dest);
+
 	FreeQueryDesc(es->qd);
 	es->qd = NULL;
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.128 2008/10/31 21:07:55 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.129 2008/11/27 00:10:04 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -501,6 +501,8 @@ postquel_end(execution_state *es)`
`501`	`501`	`PopActiveSnapshot();`
`502`	`502`	`}`
`503`	`503`
	`504`	`+ (*es->qd->dest->rDestroy) (es->qd->dest);`
	`505`	`+`
`504`	`506`	`FreeQueryDesc(es->qd);`
`505`	`507`	`es->qd = NULL;`
`506`	`508`	`}`