Don't make --enable-cassert turn on RANDOMIZE_ALLOCATED_MEMORY automatically;

tglsfdc · tglsfdc · commit c96439b5a051 · 2008-07-12T02:28:43.000Z
it's just too dang expensive.  Per recent discussion, but I just got my
nose rubbed in it again while doing some performance checking.
diff --git a/src/include/pg_config_manual.h b/src/include/pg_config_manual.h
@@ -6,7 +6,7 @@
  * for developers.	If you edit any of these, be sure to do a *full*
  * rebuild (and an initdb if noted).
  *
- * $PostgreSQL: pgsql/src/include/pg_config_manual.h,v 1.34 2008/06/24 17:58:27 tgl Exp $
+ * $PostgreSQL: pgsql/src/include/pg_config_manual.h,v 1.35 2008/07/12 02:28:43 tgl Exp $
  *------------------------------------------------------------------------
  */
 
@@ -154,15 +154,6 @@
  *------------------------------------------------------------------------
  */
 
-/*
- * Define this to cause palloc()'d memory to be filled with random data, to
- * facilitate catching code that depends on the contents of uninitialized
- * memory.  Right now, this gets defined automatically if --enable-cassert.
- */
-#ifdef USE_ASSERT_CHECKING
-#define RANDOMIZE_ALLOCATED_MEMORY
-#endif
-
 /*
  * Define this to cause pfree()'d memory to be cleared immediately, to
  * facilitate catching bugs that refer to already-freed values.
@@ -181,6 +172,13 @@
 #define MEMORY_CONTEXT_CHECKING
 #endif
 
+/*
+ * Define this to cause palloc()'d memory to be filled with random data, to
+ * facilitate catching code that depends on the contents of uninitialized
+ * memory.  Caution: this is horrendously expensive.
+ */
+/* #define RANDOMIZE_ALLOCATED_MEMORY */
+
 /*
  * Define this to force all parse and plan trees to be passed through
  * copyObject(), to facilitate catching errors and omissions in
