Revert bf08f22

simonat2ndQuadrant · simonat2ndQuadrant · commit cac0e3668297 · 2016-04-06T14:03:46.000+01:00
Remove recent changes to logging XLOG_RUNNING_XACTS by request.
diff --git a/src/backend/postmaster/bgwriter.c b/src/backend/postmaster/bgwriter.c
@@ -330,11 +330,8 @@ BackgroundWriterMain(void)
 			if (now >= timeout &&
 				last_snapshot_lsn != GetXLogInsertRecPtr())
 			{
-				XLogRecPtr log_standby_lsn = LogStandbySnapshot();
-
+				last_snapshot_lsn = LogStandbySnapshot();
 				last_snapshot_ts = now;
-				if (!XLogRecPtrIsInvalid(log_standby_lsn))
-					last_snapshot_lsn = log_standby_lsn;
 			}
 		}
 
diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
@@ -902,7 +902,6 @@ LogStandbySnapshot(void)
 	RunningTransactions running;
 	xl_standby_lock *locks;
 	int			nlocks;
-	static bool last_snapshot_overflowed = false;
 
 	Assert(XLogStandbyInfoActive());
 
@@ -933,28 +932,8 @@ LogStandbySnapshot(void)
 	 * only a shared lock.
 	 */
 	if (wal_level < WAL_LEVEL_LOGICAL)
-	{
 		LWLockRelease(ProcArrayLock);
 
-		/*
-		 * Don't bother to log anything if nothing is happening, if we are
-		 * using archive_timeout > 0 and we didn't overflow snapshot last time.
-		 *
-		 * This ensures that we don't issue an empty WAL record, which can
-		 * be annoying when used in conjunction with archive timeout.
-		 */
-		if (running->xcnt == 0 &&
-			nlocks == 0 &&
-			XLogArchiveTimeout > 0 &&
-			!last_snapshot_overflowed)
-		{
-			LWLockRelease(XidGenLock);
-			return InvalidXLogRecPtr;
-		}
-
-		last_snapshot_overflowed = running->subxid_overflow;
-	}
-
 	recptr = LogCurrentRunningXacts(running);
 
 	/* Release lock if we kept it longer ... */

Original file line number	Diff line number	Diff line change
`@@ -330,11 +330,8 @@ BackgroundWriterMain(void)`
`330`	`330`	`if (now >= timeout &&`
`331`	`331`	`last_snapshot_lsn != GetXLogInsertRecPtr())`
`332`	`332`	`{`
`333`		`- XLogRecPtr log_standby_lsn = LogStandbySnapshot();`
`334`		`-`
	`333`	`+ last_snapshot_lsn = LogStandbySnapshot();`
`335`	`334`	`last_snapshot_ts = now;`
`336`		`- if (!XLogRecPtrIsInvalid(log_standby_lsn))`
`337`		`- last_snapshot_lsn = log_standby_lsn;`
`338`	`335`	`}`
`339`	`336`	`}`
`340`	`337`