Remove a couple of useless pstrdup() calls.

tglsfdc · tglsfdc · commit cc402116ca15 · 2016-03-09T23:29:05.000-05:00
There's no point in pstrdup'ing the result of TextDatumGetCString,
since that's necessarily already a freshly-palloc'd C string.

These particular calls are unlikely to be of any consequence
performance-wise, but still they're a bad precedent that can confuse
future patch authors.

Noted by Chapman Flack.
diff --git a/src/backend/foreign/foreign.c b/src/backend/foreign/foreign.c
@@ -121,14 +121,14 @@ GetForeignServer(Oid serverid)
 							tp,
 							Anum_pg_foreign_server_srvtype,
 							&isnull);
-	server->servertype = isnull ? NULL : pstrdup(TextDatumGetCString(datum));
+	server->servertype = isnull ? NULL : TextDatumGetCString(datum);
 
 	/* Extract server version */
 	datum = SysCacheGetAttr(FOREIGNSERVEROID,
 							tp,
 							Anum_pg_foreign_server_srvversion,
 							&isnull);
-	server->serverversion = isnull ? NULL : pstrdup(TextDatumGetCString(datum));
+	server->serverversion = isnull ? NULL : TextDatumGetCString(datum);
 
 	/* Extract the srvoptions */
 	datum = SysCacheGetAttr(FOREIGNSERVEROID,
