Fix up compiler warnings/errors from f4fb45d.

tglsfdc · tglsfdc · commit cc7401d5ca49 · 2022-03-27T18:32:40.000-04:00
Per early buildfarm returns.
diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
@@ -3415,15 +3415,13 @@ transformJsonConstructorOutput(ParseState *pstate, JsonOutput *output,
 	if (!OidIsValid(returning->typid))
 	{
 		ListCell   *lc;
-		bool		have_json = false;
 		bool		have_jsonb = false;
 
 		foreach(lc, args)
 		{
 			Node	   *expr = lfirst(lc);
 			Oid			typid = exprType(expr);
 
-			have_json |= typid == JSONOID;
 			have_jsonb |= typid == JSONBOID;
 
 			if (have_jsonb)
@@ -3437,8 +3435,6 @@ transformJsonConstructorOutput(ParseState *pstate, JsonOutput *output,
 		}
 		else
 		{
-			/* Note: this includes the have_json case */
-			
 			/* XXX TEXT is default by the standard, but we return JSON */
 			returning->typid = JSONOID;
 			returning->format->format_type = JS_FORMAT_JSON;
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -9907,9 +9907,11 @@ get_json_constructor(JsonConstructorExpr *ctor, deparse_context *context,
 			funcname = "JSON_ARRAY";
 			break;
 		case JSCTOR_JSON_OBJECTAGG:
-			return get_json_agg_constructor(ctor, context, "JSON_OBJECTAGG", true);
+			get_json_agg_constructor(ctor, context, "JSON_OBJECTAGG", true);
+			return;
 		case JSCTOR_JSON_ARRAYAGG:
-			return get_json_agg_constructor(ctor, context, "JSON_ARRAYAGG", false);
+			get_json_agg_constructor(ctor, context, "JSON_ARRAYAGG", false);
+			return;
 		default:
 			elog(ERROR, "invalid JsonConstructorExprType %d", ctor->type);
 	}
@@ -10064,8 +10066,8 @@ get_agg_expr_helper(Aggref *aggref, deparse_context *context,
 static void
 get_agg_expr(Aggref *aggref, deparse_context *context, Aggref *original_aggref)
 {
-	return get_agg_expr_helper(aggref, context, original_aggref, NULL, NULL,
-							   false);
+	get_agg_expr_helper(aggref, context, original_aggref, NULL, NULL,
+						false);
 }
 
 /*
@@ -10182,7 +10184,7 @@ get_windowfunc_expr_helper(WindowFunc *wfunc, deparse_context *context,
 static void
 get_windowfunc_expr(WindowFunc *wfunc, deparse_context *context)
 {
-	return get_windowfunc_expr_helper(wfunc, context, NULL, NULL, false);
+	get_windowfunc_expr_helper(wfunc, context, NULL, NULL, false);
 }
 
 /*
@@ -10438,13 +10440,13 @@ get_json_agg_constructor(JsonConstructorExpr *ctor, deparse_context *context,
 	get_json_constructor_options(ctor, &options);
 
 	if (IsA(ctor->func, Aggref))
-		return get_agg_expr_helper((Aggref *) ctor->func, context,
-								   (Aggref *) ctor->func,
-								   funcname, options.data, is_json_objectagg);
+		get_agg_expr_helper((Aggref *) ctor->func, context,
+							(Aggref *) ctor->func,
+							funcname, options.data, is_json_objectagg);
 	else if (IsA(ctor->func, WindowFunc))
-		return get_windowfunc_expr_helper((WindowFunc *) ctor->func, context,
-										  funcname, options.data,
-										  is_json_objectagg);
+		get_windowfunc_expr_helper((WindowFunc *) ctor->func, context,
+								   funcname, options.data,
+								   is_json_objectagg);
 	else
 		elog(ERROR, "invalid JsonConstructorExpr underlying node type: %d",
 			 nodeTag(ctor->func));

Original file line number	Diff line number	Diff line change
`@@ -3415,15 +3415,13 @@ transformJsonConstructorOutput(ParseState pstate, JsonOutput output,`
`3415`	`3415`	`if (!OidIsValid(returning->typid))`
`3416`	`3416`	`{`
`3417`	`3417`	`ListCell *lc;`
`3418`		`- bool have_json = false;`
`3419`	`3418`	`bool have_jsonb = false;`
`3420`	`3419`
`3421`	`3420`	`foreach(lc, args)`
`3422`	`3421`	`{`
`3423`	`3422`	`Node *expr = lfirst(lc);`
`3424`	`3423`	`Oid typid = exprType(expr);`
`3425`	`3424`
`3426`		`- have_json \|= typid == JSONOID;`
`3427`	`3425`	`have_jsonb \|= typid == JSONBOID;`
`3428`	`3426`
`3429`	`3427`	`if (have_jsonb)`
`@@ -3437,8 +3435,6 @@ transformJsonConstructorOutput(ParseState pstate, JsonOutput output,`
`3437`	`3435`	`}`
`3438`	`3436`	`else`
`3439`	`3437`	`{`
`3440`		`- /* Note: this includes the have_json case */`
`3441`		`-`
`3442`	`3438`	`/* XXX TEXT is default by the standard, but we return JSON */`
`3443`	`3439`	`returning->typid = JSONOID;`
`3444`	`3440`	`returning->format->format_type = JS_FORMAT_JSON;`