Teach appendShellString() to not quote strings containing "-".

tglsfdc · tglsfdc · commit cdc70597c9ba · 2016-09-06T14:53:31.000-04:00
Brain fade in commit a00c583: I was thinking that a string starting with "-" could be taken as a switch depending on command line syntax. That's true, but having appendShellString() quote it will not help, so we may as well not do so. Per complaint from Peter Eisentraut.
diff --git a/src/fe_utils/string_utils.c b/src/fe_utils/string_utils.c
@@ -439,7 +439,7 @@ appendShellString(PQExpBuffer buf, const char *str)
 	 * contains only safe characters.
 	 */
 	if (*str != '\0' &&
-		strspn(str, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_./:") == strlen(str))
+		strspn(str, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_./:") == strlen(str))
 	{
 		appendPQExpBufferStr(buf, str);
 		return;

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,7 @@ appendShellString(PQExpBuffer buf, const char *str)`
`439`	`439`	`* contains only safe characters.`
`440`	`440`	`*/`
`441`	`441`	`if (*str != '\0' &&`
`442`		`- strspn(str, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_./:") == strlen(str))`
	`442`	`+ strspn(str, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_./:") == strlen(str))`
`443`	`443`	`{`
`444`	`444`	`appendPQExpBufferStr(buf, str);`
`445`	`445`	`return;`