Get a snapshot before COPY in table sync

petere · petere · commit cf6520183328 · 2017-08-02T11:34:42.000-04:00
This fixes a crash if the local table has a function index and the
function makes non-immutable calls.

Reported-by: Scott Milliken &lt;scott@deltaex.com&gt;
Author: Masahiko Sawada &lt;sawada.mshk@gmail.com&gt;
diff --git a/src/backend/replication/logical/tablesync.c b/src/backend/replication/logical/tablesync.c
@@ -917,7 +917,9 @@ LogicalRepSyncTableStart(XLogRecPtr *origin_startpos)
 				walrcv_create_slot(wrconn, slotname, true,
 								   CRS_USE_SNAPSHOT, origin_startpos);
 
+				PushActiveSnapshot(GetTransactionSnapshot());
 				copy_table(rel);
+				PopActiveSnapshot();
 
 				res = walrcv_exec(wrconn, "COMMIT", 0, NULL);
 				if (res->status != WALRCV_OK_COMMAND)
