Remove unnecessary heap_tuple_needs_freeze argument.

petergeoghegan · petergeoghegan · commit cf879d3069a3 · 2022-02-24T18:31:07.000-08:00
The buffer argument hasn't been used since the function was first added by commit bbb6e55. The sibling heap_prepare_freeze_tuple function doesn't have such an argument either. Remove it.
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -7141,7 +7141,7 @@ heap_tuple_needs_eventual_freeze(HeapTupleHeader tuple)
  */
 bool
 heap_tuple_needs_freeze(HeapTupleHeader tuple, TransactionId cutoff_xid,
-						MultiXactId cutoff_multi, Buffer buf)
+						MultiXactId cutoff_multi)
 {
 	TransactionId xid;
 
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
@@ -2015,7 +2015,7 @@ lazy_scan_noprune(LVRelState *vacrel,
 		tupleheader = (HeapTupleHeader) PageGetItem(page, itemid);
 		if (heap_tuple_needs_freeze(tupleheader,
 									vacrel->FreezeLimit,
-									vacrel->MultiXactCutoff, buf))
+									vacrel->MultiXactCutoff))
 		{
 			if (vacrel->aggressive)
 			{
diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h
@@ -168,7 +168,7 @@ extern bool heap_freeze_tuple(HeapTupleHeader tuple,
 							  TransactionId relfrozenxid, TransactionId relminmxid,
 							  TransactionId cutoff_xid, TransactionId cutoff_multi);
 extern bool heap_tuple_needs_freeze(HeapTupleHeader tuple, TransactionId cutoff_xid,
-									MultiXactId cutoff_multi, Buffer buf);
+									MultiXactId cutoff_multi);
 extern bool heap_tuple_needs_eventual_freeze(HeapTupleHeader tuple);
 
 extern void simple_heap_insert(Relation relation, HeapTuple tup);

Original file line number	Diff line number	Diff line change
`@@ -7141,7 +7141,7 @@ heap_tuple_needs_eventual_freeze(HeapTupleHeader tuple)`
`7141`	`7141`	`*/`
`7142`	`7142`	`bool`
`7143`	`7143`	`heap_tuple_needs_freeze(HeapTupleHeader tuple, TransactionId cutoff_xid,`
`7144`		`- MultiXactId cutoff_multi, Buffer buf)`
	`7144`	`+ MultiXactId cutoff_multi)`
`7145`	`7145`	`{`
`7146`	`7146`	`TransactionId xid;`
`7147`	`7147`
Original file line number	Diff line number	Diff line change
`@@ -2015,7 +2015,7 @@ lazy_scan_noprune(LVRelState *vacrel,`
`2015`	`2015`	`tupleheader = (HeapTupleHeader) PageGetItem(page, itemid);`
`2016`	`2016`	`if (heap_tuple_needs_freeze(tupleheader,`
`2017`	`2017`	`vacrel->FreezeLimit,`
`2018`		`- vacrel->MultiXactCutoff, buf))`
	`2018`	`+ vacrel->MultiXactCutoff))`
`2019`	`2019`	`{`
`2020`	`2020`	`if (vacrel->aggressive)`
`2021`	`2021`	`{`