Fix missing parentheses resulting in wrong order of dereference.

robertmhaas · robertmhaas · commit d02c0ddb1529 · 2014-01-15T11:00:50.000-05:00
This could result in referencing uninitialized memory.

Michael Paquier, in response to a complaint from Andres Freund
diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c
@@ -2156,7 +2156,7 @@ toast_open_indexes(Relation toastrel,
 	/* Fetch the first valid index in list */
 	for (i = 0; i < *num_indexes; i++)
 	{
-		Relation toastidx = *toastidxs[i];
+		Relation toastidx = (*toastidxs)[i];
 		if (toastidx->rd_index->indisvalid)
 		{
 			res = i;

Original file line number	Diff line number	Diff line change
`@@ -2156,7 +2156,7 @@ toast_open_indexes(Relation toastrel,`
`2156`	`2156`	`/* Fetch the first valid index in list */`
`2157`	`2157`	`for (i = 0; i < *num_indexes; i++)`
`2158`	`2158`	`{`
`2159`		`- Relation toastidx = *toastidxs[i];`
	`2159`	`+ Relation toastidx = (*toastidxs)[i];`
`2160`	`2160`	`if (toastidx->rd_index->indisvalid)`
`2161`	`2161`	`{`
`2162`	`2162`	`res = i;`