Skip to content

Commit d0303bc

Browse files
committed
Fix outdated comment that talked about seek position of WAL file.
Since commit c24dcd0, we have been using pg_pread() to read the WAL file, which doesn't change the seek position (unless we fall back to the implementation in src/port/pread.c). Update comment accordingly. Backpatch-through: 12, where we started to use pg_pread()
1 parent d3c8784 commit d0303bc

File tree

1 file changed

+3
-5
lines changed
  • src/backend/access/transam

1 file changed

+3
-5
lines changed

src/backend/access/transam/xlog.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -809,11 +809,9 @@ static XLogSegNo openLogSegNo = 0;
809809

810810
/*
811811
* These variables are used similarly to the ones above, but for reading
812-
* the XLOG. Note, however, that readOff generally represents the offset
813-
* of the page just read, not the seek position of the FD itself, which
814-
* will be just past that page. readLen indicates how much of the current
815-
* page has been read into readBuf, and readSource indicates where we got
816-
* the currently open file from.
812+
* the XLOG. readOff is the offset of the page just read, readLen
813+
* indicates how much of it has been read into readBuf, and readSource
814+
* indicates where we got the currently open file from.
817815
* Note: we could use Reserve/ReleaseExternalFD to track consumption of
818816
* this FD too; but it doesn't currently seem worthwhile, since the XLOG is
819817
* not read by general-purpose sessions.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy