Allow HotStandbyActiveInReplay() to be called in single user mode.

anarazel · anarazel · commit d1b958218ac1 · 2015-06-08T14:09:27.000+02:00
HotStandbyActiveInReplay, introduced in 061b079, only allowed WAL replay to happen in the startup process, missing the single user case. This buglet is fairly harmless as it only causes problems when single user mode in an assertion enabled build is used to replay a btree vacuum record. Backpatch to 9.2. 061b079 was backpatched further, but the assertion was not.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -7587,7 +7587,7 @@ HotStandbyActive(void)
 bool
 HotStandbyActiveInReplay(void)
 {
-	Assert(AmStartupProcess());
+	Assert(AmStartupProcess() || !IsPostmasterEnvironment);
 	return LocalHotStandbyActive;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7587,7 +7587,7 @@ HotStandbyActive(void)`
`7587`	`7587`	`bool`
`7588`	`7588`	`HotStandbyActiveInReplay(void)`
`7589`	`7589`	`{`
`7590`		`- Assert(AmStartupProcess());`
	`7590`	`+ Assert(AmStartupProcess() \|\| !IsPostmasterEnvironment);`
`7591`	`7591`	`return LocalHotStandbyActive;`
`7592`	`7592`	`}`
`7593`	`7593`