Fix dumping of DEFERRABLE/INITIALLY DEFERRED:

bmomjian · bmomjian · commit d31b20af693d · 2003-01-08T22:54:06.000Z
&gt; The big problem is that while pg_dump's dump_trigger() looks at
&gt; tginitdeferred and dumps accordingly, pg_get_constraintdef doesn't look
&gt; at tginitdeferred, and therefore doesn't record the requirement as part
&gt; of ALTER TABLE ADD CONSTRAINT.

pg_get_constraintdef should probably be looking at condeferrable and
condeferred in the pg_constraint row it's looking at.  Maybe something
like the attached.

(Added, output only non-default values.)

Stephan Szabo
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -3,7 +3,7 @@
  *				back to source text
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.129 2002/12/14 00:17:59 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.130 2003/01/08 22:54:06 momjian Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -688,6 +688,11 @@ pg_get_constraintdef(PG_FUNCTION_ARGS)
 				}
 				appendStringInfo(&buf, " ON DELETE %s", string);
 
+				if (conForm->condeferrable)
+					appendStringInfo(&buf, " DEFERRABLE");
+				if (conForm->condeferred)
+					appendStringInfo(&buf, " INITIALLY DEFERRED");
+
 				break;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* back to source text`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.129 2002/12/14 00:17:59 tgl Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.130 2003/01/08 22:54:06 momjian Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -688,6 +688,11 @@ pg_get_constraintdef(PG_FUNCTION_ARGS)`
`688`	`688`	`}`
`689`	`689`	`appendStringInfo(&buf, " ON DELETE %s", string);`
`690`	`690`
	`691`	`+ if (conForm->condeferrable)`
	`692`	`+ appendStringInfo(&buf, " DEFERRABLE");`
	`693`	`+ if (conForm->condeferred)`
	`694`	`+ appendStringInfo(&buf, " INITIALLY DEFERRED");`
	`695`	`+`
`691`	`696`	`break;`
`692`	`697`	`}`
`693`	`698`