Fix typo in PQconnectStartParams().

tglsfdc · tglsfdc · commit d518d6a16879 · 2011-04-02T18:05:42.000-04:00
This would lead to leaking the PGconn structure after an error detected by
conninfo_array_parse(), as well as failing to return a useful error message
in such cases.  Backpatch to 9.0 where the error was introduced.

Joseph Adams
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -491,7 +491,7 @@ PQconnectStartParams(const char **keywords,
 	{
 		conn->status = CONNECTION_BAD;
 		/* errorMessage is already set */
-		return false;
+		return conn;
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ PQconnectStartParams(const char **keywords,`
`491`	`491`	`{`
`492`	`492`	`conn->status = CONNECTION_BAD;`
`493`	`493`	`/* errorMessage is already set */`
`494`		`- return false;`
	`494`	`+ return conn;`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`/*`