Don't try to use a constraint name as domain name

alvherre · alvherre · commit d66516207786 · 2011-07-04T14:33:44.000-04:00
The bug that caused this to be discovered is that the code was trying to
dereference a NULL or ill-defined pointer, as reported by Michael Mueller;
but what it was doing was wrong anyway, per Heikki.

This patch is Heikki's suggested fix.
diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c
@@ -2096,13 +2096,13 @@ AlterDomainValidateConstraint(List *names, char *constrName)
 		ereport(ERROR,
 				(errcode(ERRCODE_UNDEFINED_OBJECT),
 				 errmsg("constraint \"%s\" of domain \"%s\" does not exist",
-						constrName, NameStr(con->conname))));
+						constrName, TypeNameToString(typename))));
 
 	if (con->contype != CONSTRAINT_CHECK)
 		ereport(ERROR,
 				(errcode(ERRCODE_WRONG_OBJECT_TYPE),
 				 errmsg("constraint \"%s\" of domain \"%s\" is not a check constraint",
-						constrName, NameStr(con->conname))));
+						constrName, TypeNameToString(typename))));
 
 	val = SysCacheGetAttr(CONSTROID, tuple,
 						  Anum_pg_constraint_conbin,
