Commit d6c0db1

committed

pgstat: Hide instability in stats.spec with -DCATCACHE_FORCE_RELEASE.

With -DCATCACHE_FORCE_RELEASE a few tests failed. Those were trying to test behavior in the absence of invalidation processing and -DCATCACHE_FORCE_RELEASE obviously adds a lot of invalidation processing. The test already tried to handle debug_discard_caches > 0, by disabling it for individual tests. Instead hide potentially problematic function calls in a wrapper function that catches the does-not-exist error. The error isn't the actually interesting bit, it's whether the stats entry still exist afterwards. I confirmed that the tests still catches leaked function stats if I nuke the protections against that in pgstat_function.c. Per buildfarm animal prion. Discussion: https://postgr.es/m/20220407165709.jgdkrzqlkcwue6ko@alap3.anarazel.de

1 parent 5264add commit d6c0db1Copy full SHA for d6c0db1

3 files changed

+172

-170

lines changed

src/test/isolation
- expected
  - stats.out
  - stats_1.out
- specs
  - stats.spec

3 files changed

+172

-170

lines changed

Comments

(0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit d6c0db1

3 files changed

3 files changed

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

File tree

3 files changed

3 files changed

0 commit comments

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.