Fixup for prefetching support on macOS

petere · petere · commit d7fe02fb9e6e · 2024-08-29T08:22:28.000+02:00
The new code path (commit 6654bb9) should call FileAccess() first, like the posix_fadvise() path. Reported-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/0827edec-1317-4917-a186-035eb1e3241d%40eisentraut.org
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -2110,6 +2110,10 @@ FilePrefetch(File file, off_t offset, off_t amount, uint32 wait_event_info)
 		}			ra;
 		int			returnCode;
 
+		returnCode = FileAccess(file);
+		if (returnCode < 0)
+			return returnCode;
+
 		ra.ra_offset = offset;
 		ra.ra_count = amount;
 		pgstat_report_wait_start(wait_event_info);
