Turn off WalSender keepalives by default, users can enable if desired

simonat2ndQuadrant · simonat2ndQuadrant · commit da4efa13d801 · 2012-08-09T17:07:03.000+01:00
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -837,7 +837,7 @@ WalSndLoop(void)
 
 			if (pq_is_send_pending())
 				wakeEvents |= WL_SOCKET_WRITEABLE;
-			else
+			else if (MyWalSnd->sendKeepalive)
 			{
 				WalSndKeepalive(output_message);
 				/* Try to flush pending output to the client */
diff --git a/src/include/replication/walsender_private.h b/src/include/replication/walsender_private.h
@@ -37,6 +37,7 @@ typedef struct WalSnd
 	XLogRecPtr	sentPtr;		/* WAL has been sent up to this point */
 	bool		needreload;		/* does currently-open file need to be
 								 * reloaded? */
+	bool		sendKeepalive;	/* do we send keepalives on this connection? */
 
 	/*
 	 * The xlog locations that have been written, flushed, and applied by

Original file line number	Diff line number	Diff line change
`@@ -837,7 +837,7 @@ WalSndLoop(void)`
`837`	`837`
`838`	`838`	`if (pq_is_send_pending())`
`839`	`839`	`wakeEvents \|= WL_SOCKET_WRITEABLE;`
`840`		`- else`
	`840`	`+ else if (MyWalSnd->sendKeepalive)`
`841`	`841`	`{`
`842`	`842`	`WalSndKeepalive(output_message);`
`843`	`843`	`/* Try to flush pending output to the client */`