Replace static buf with a stack-allocated one in ReadControlFile

hlinnaka · hlinnaka · commit da8a587e2e22 · 2024-07-30T22:05:59.000+03:00
It's only used very locally within the function. Reviewed-by: Robert Haas Discussion: https://www.postgresql.org/message-id/7f86e06a-98c5-4ce3-8ec9-3885c8de0358@iki.fi
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -4314,7 +4314,7 @@ ReadControlFile(void)
 {
 	pg_crc32c	crc;
 	int			fd;
-	static char wal_segsz_str[20];
+	char		wal_segsz_str[20];
 	int			r;
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -4314,7 +4314,7 @@ ReadControlFile(void)`
`4314`	`4314`	`{`
`4315`	`4315`	`pg_crc32c crc;`
`4316`	`4316`	`int fd;`
`4317`		`- static char wal_segsz_str[20];`
	`4317`	`+ char wal_segsz_str[20];`
`4318`	`4318`	`int r;`
`4319`	`4319`
`4320`	`4320`	`/*`