Skip to content

Commit dbbca2c

Browse files
committed
Remove unused #include's from backend .c files
as determined by include-what-you-use (IWYU) While IWYU also suggests to *add* a bunch of #include's (which is its main purpose), this patch does not do that. In some cases, a more specific #include replaces another less specific one. Some manual adjustments of the automatic result: - IWYU currently doesn't know about includes that provide global variable declarations (like -Wmissing-variable-declarations), so those includes are being kept manually. - All includes for port(ability) headers are being kept for now, to play it safe. - No changes of catalog/pg_foo.h to catalog/pg_foo_d.h, to keep the patch from exploding in size. Note that this patch touches just *.c files, so nothing declared in header files changes in hidden ways. As a small example, in src/backend/access/transam/rmgr.c, some IWYU pragma annotations are added to handle a special case there. Discussion: https://www.postgresql.org/message-id/flat/af837490-6b2f-46df-ba05-37ea6a6653fc%40eisentraut.org
1 parent 24eebc6 commit dbbca2c

File tree

425 files changed

+230
-994
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

425 files changed

+230
-994
lines changed

src/backend/access/brin/brin.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
#include "storage/freespace.h"
3636
#include "tcop/tcopprot.h" /* pgrminclude ignore */
3737
#include "utils/acl.h"
38-
#include "utils/builtins.h"
3938
#include "utils/datum.h"
39+
#include "utils/fmgrprotos.h"
4040
#include "utils/guc.h"
4141
#include "utils/index_selfuncs.h"
4242
#include "utils/memutils.h"

src/backend/access/brin/brin_bloom.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,17 +119,14 @@
119119
#include "access/brin_internal.h"
120120
#include "access/brin_page.h"
121121
#include "access/brin_tuple.h"
122-
#include "access/hash.h"
123122
#include "access/htup_details.h"
124123
#include "access/reloptions.h"
125-
#include "access/stratnum.h"
124+
#include "catalog/pg_am.h"
126125
#include "catalog/pg_type.h"
127126
#include "catalog/pg_amop.h"
128-
#include "utils/builtins.h"
129-
#include "utils/datum.h"
130-
#include "utils/lsyscache.h"
127+
#include "common/hashfn.h"
128+
#include "utils/fmgrprotos.h"
131129
#include "utils/rel.h"
132-
#include "utils/syscache.h"
133130

134131
#include <math.h>
135132

src/backend/access/brin/brin_inclusion.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
#include "access/skey.h"
3131
#include "catalog/pg_amop.h"
3232
#include "catalog/pg_type.h"
33-
#include "utils/builtins.h"
3433
#include "utils/datum.h"
34+
#include "utils/fmgrprotos.h"
3535
#include "utils/lsyscache.h"
3636
#include "utils/rel.h"
3737
#include "utils/syscache.h"

src/backend/access/brin/brin_minmax.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,10 @@
1212

1313
#include "access/brin_internal.h"
1414
#include "access/brin_tuple.h"
15-
#include "access/genam.h"
1615
#include "access/stratnum.h"
1716
#include "catalog/pg_amop.h"
18-
#include "catalog/pg_type.h"
19-
#include "utils/builtins.h"
2017
#include "utils/datum.h"
18+
#include "utils/fmgrprotos.h"
2119
#include "utils/lsyscache.h"
2220
#include "utils/rel.h"
2321
#include "utils/syscache.h"

src/backend/access/brin/brin_minmax_multi.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
#include "utils/inet.h"
7878
#include "utils/lsyscache.h"
7979
#include "utils/memutils.h"
80-
#include "utils/numeric.h"
8180
#include "utils/pg_lsn.h"
8281
#include "utils/rel.h"
8382
#include "utils/syscache.h"

src/backend/access/brin/brin_pageops.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "storage/bufmgr.h"
2020
#include "storage/freespace.h"
2121
#include "storage/lmgr.h"
22-
#include "storage/smgr.h"
2322
#include "utils/rel.h"
2423

2524
/*

src/backend/access/brin/brin_revmap.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include "access/xloginsert.h"
3030
#include "miscadmin.h"
3131
#include "storage/bufmgr.h"
32-
#include "storage/lmgr.h"
3332
#include "utils/rel.h"
3433

3534

src/backend/access/common/attmap.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "postgres.h"
2424

2525
#include "access/attmap.h"
26-
#include "access/htup_details.h"
2726
#include "utils/builtins.h"
2827

2928

src/backend/access/common/heaptuple.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
#include "access/sysattr.h"
6262
#include "access/tupdesc_details.h"
6363
#include "common/hashfn.h"
64-
#include "executor/tuptable.h"
6564
#include "utils/datum.h"
6665
#include "utils/expandeddatum.h"
6766
#include "utils/hsearch.h"

src/backend/access/common/printtup.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include "postgres.h"
1717

1818
#include "access/printtup.h"
19-
#include "libpq/libpq.h"
2019
#include "libpq/pqformat.h"
2120
#include "tcop/pquery.h"
2221
#include "utils/lsyscache.h"

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy