Allocate fresh memory for post_opts/exec_path

sfrost · sfrost · commit dd917bb793b2 · 2014-03-05T08:50:12.000-05:00
Instead of having read_post_opts() depend on the memory allocated for
the config file (which is now getting free'd), pg_strdup() for
post_opts and exec_path (similar to how it's being done elsewhere).

Noted by Thom Brown.
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
@@ -730,10 +730,10 @@ read_post_opts(void)
 				{
 					*arg1 = '\0';		/* terminate so we get only program
 										 * name */
-					post_opts = arg1 + 1;		/* point past whitespace */
+					post_opts = pg_strdup(arg1 + 1); /* point past whitespace */
 				}
 				if (exec_path == NULL)
-					exec_path = optline;
+					exec_path = pg_strdup(optline);
 			}
 
 			/* Free the results of readfile. */

Original file line number	Diff line number	Diff line change
`@@ -730,10 +730,10 @@ read_post_opts(void)`
`730`	`730`	`{`
`731`	`731`	`arg1 = '\0'; / terminate so we get only program`
`732`	`732`	`* name */`
`733`		`- post_opts = arg1 + 1; /* point past whitespace */`
	`733`	`+ post_opts = pg_strdup(arg1 + 1); /* point past whitespace */`
`734`	`734`	`}`
`735`	`735`	`if (exec_path == NULL)`
`736`		`- exec_path = optline;`
	`736`	`+ exec_path = pg_strdup(optline);`
`737`	`737`	`}`
`738`	`738`
`739`	`739`	`/* Free the results of readfile. */`