Remove unused function declaration in logicalproto.h.

Amit Kapila · Amit Kapila · commit ddd5f6d2609b · 2020-09-12T07:47:53.000+05:30
In the passing, fix a typo in pgoutput.c. Reported-by: Tomas Vondra Author: Tomas Vondra Reviewed-by: Dilip Kumar Discussion: https://postgr.es/m/20200909084353.pncuclpbwlr7vylh@development
diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c
@@ -77,7 +77,7 @@ static void send_relation_and_attrs(Relation relation, TransactionId xid,
  * and with streamed transactions the commit order may be different from
  * the order the transactions are sent in. Also, the (sub) transactions
  * might get aborted so we need to send the schema for each (sub) transaction
- * so that we don't loose the schema information on abort. For handling this,
+ * so that we don't lose the schema information on abort. For handling this,
  * we maintain the list of xids (streamed_txns) for those we have already sent
  * the schema.
  *
diff --git a/src/include/replication/logicalproto.h b/src/include/replication/logicalproto.h
@@ -133,7 +133,6 @@ extern void logicalrep_write_stream_start(StringInfo out, TransactionId xid,
 extern TransactionId logicalrep_read_stream_start(StringInfo in,
 												  bool *first_segment);
 extern void logicalrep_write_stream_stop(StringInfo out);
-extern TransactionId logicalrep_read_stream_stop(StringInfo in);
 extern void logicalrep_write_stream_commit(StringInfo out, ReorderBufferTXN *txn,
 										   XLogRecPtr commit_lsn);
 extern TransactionId logicalrep_read_stream_commit(StringInfo out,

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ static void send_relation_and_attrs(Relation relation, TransactionId xid,`
`77`	`77`	`* and with streamed transactions the commit order may be different from`
`78`	`78`	`* the order the transactions are sent in. Also, the (sub) transactions`
`79`	`79`	`* might get aborted so we need to send the schema for each (sub) transaction`
`80`		`- * so that we don't loose the schema information on abort. For handling this,`
	`80`	`+ * so that we don't lose the schema information on abort. For handling this,`
`81`	`81`	`* we maintain the list of xids (streamed_txns) for those we have already sent`
`82`	`82`	`* the schema.`
`83`	`83`	`*`