Assert(IsTransactionState()) in RelationIdGetRelation().

tglsfdc · tglsfdc · commit ddfc9cb054ab · 2014-02-06T11:28:13.000-05:00
Commit 42c80c6 added an Assert(IsTransactionState()) in SearchCatCache(), to catch any code that thought it could do a catcache lookup outside transactions. Extend the same idea to relcache lookups.
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
@@ -1578,6 +1578,9 @@ RelationIdGetRelation(Oid relationId)
 {
 	Relation	rd;
 
+	/* Make sure we're in an xact, even if this ends up being a cache hit */
+	Assert(IsTransactionState());
+
 	/*
 	 * first try to find reldesc in the cache
 	 */

Original file line number	Diff line number	Diff line change
`@@ -1578,6 +1578,9 @@ RelationIdGetRelation(Oid relationId)`
`1578`	`1578`	`{`
`1579`	`1579`	`Relation rd;`
`1580`	`1580`
	`1581`	`+ /* Make sure we're in an xact, even if this ends up being a cache hit */`
	`1582`	`+ Assert(IsTransactionState());`
	`1583`	`+`
`1581`	`1584`	`/*`
`1582`	`1585`	`* first try to find reldesc in the cache`
`1583`	`1586`	`*/`