genericcostestimate() neglected to include qual startup cost in

tglsfdc · tglsfdc · commit df79b847fe8e · 2004-02-27T21:44:34.000Z
indexTotalCost.  I think this may not make any real difference in 7.4,
but it definitely is a problem with CVS tip's new equation.
diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c
@@ -15,7 +15,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/selfuncs.c,v 1.157 2004/02/17 00:52:53 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/selfuncs.c,v 1.158 2004/02/27 21:44:34 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4259,6 +4259,7 @@ genericcostestimate(Query *root, RelOptInfo *rel,
 	if (qual_arg_cost < 0)		/* just in case... */
 		qual_arg_cost = 0;
 	*indexStartupCost = qual_arg_cost;
+	*indexTotalCost += qual_arg_cost;
 	*indexTotalCost += numIndexTuples * (cpu_index_tuple_cost + qual_op_cost);
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`*`
`16`	`16`	`*`
`17`	`17`	`* IDENTIFICATION`
`18`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/selfuncs.c,v 1.157 2004/02/17 00:52:53 tgl Exp $`
	`18`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/selfuncs.c,v 1.158 2004/02/27 21:44:34 tgl Exp $`
`19`	`19`	`*`
`20`	`20`	`*-------------------------------------------------------------------------`
`21`	`21`	`*/`
`@@ -4259,6 +4259,7 @@ genericcostestimate(Query root, RelOptInfo rel,`
`4259`	`4259`	`if (qual_arg_cost < 0) /* just in case... */`
`4260`	`4260`	`qual_arg_cost = 0;`
`4261`	`4261`	`*indexStartupCost = qual_arg_cost;`
	`4262`	`+ *indexTotalCost += qual_arg_cost;`
`4262`	`4263`	`indexTotalCost += numIndexTuples (cpu_index_tuple_cost + qual_op_cost);`
`4263`	`4264`
`4264`	`4265`	`/*`