Ignore PQcancel errors properly

alvherre · alvherre · commit e0bf16060be6 · 2017-05-09T14:58:51.000-03:00
Add a (void) cast to all PQcancel() calls that purposefully don't check
the return value, to keep compilers and static checkers happy.

Per Coverity.
diff --git a/src/bin/pg_dump/pg_backup_db.c b/src/bin/pg_dump/pg_backup_db.c
@@ -351,12 +351,12 @@ DisconnectDatabase(Archive *AHX)
 	if (AH->connCancel)
 	{
 		/*
-		 * If we have an active query, send a cancel before closing.  This is
-		 * of no use for a normal exit, but might be helpful during
-		 * exit_horribly().
+		 * If we have an active query, send a cancel before closing, ignoring
+		 * any errors.  This is of no use for a normal exit, but might be
+		 * helpful during exit_horribly().
 		 */
 		if (PQtransactionStatus(AH->connection) == PQTRANS_ACTIVE)
-			PQcancel(AH->connCancel, errbuf, sizeof(errbuf));
+			(void) PQcancel(AH->connCancel, errbuf, sizeof(errbuf));
 
 		/*
 		 * Prevent signal handler from sending a cancel after this.
diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
@@ -860,7 +860,7 @@ DisconnectDatabase(ParallelSlot *slot)
 
 		if ((cancel = PQgetCancel(slot->connection)))
 		{
-			PQcancel(cancel, errbuf, sizeof(errbuf));
+			(void) PQcancel(cancel, errbuf, sizeof(errbuf));
 			PQfreeCancel(cancel);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -860,7 +860,7 @@ DisconnectDatabase(ParallelSlot *slot)`
`860`	`860`
`861`	`861`	`if ((cancel = PQgetCancel(slot->connection)))`
`862`	`862`	`{`
`863`		`- PQcancel(cancel, errbuf, sizeof(errbuf));`
	`863`	`+ (void) PQcancel(cancel, errbuf, sizeof(errbuf));`
`864`	`864`	`PQfreeCancel(cancel);`
`865`	`865`	`}`
`866`	`866`	`}`