Fix bogus assertion in BootstrapModeMain().

anarazel · anarazel · commit e12694523e7e · 2021-08-09T08:28:53.000-07:00
The assertion was always true, as written, thanks to me "simplifying" it
before commit.

Per coverity and Tom Lane.
diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c
@@ -215,9 +215,9 @@ BootstrapModeMain(int argc, char *argv[], bool check_only)
 	InitializeGUCOptions();
 
 	/* an initial --boot or --check should be present */
-	Assert(argc == 1
-		   || strcmp(argv[1], "--boot") != 0
-		   || strcmp(argv[1], "--check") != 0);
+	Assert(argc > 1
+		   && (strcmp(argv[1], "--boot") == 0
+			   || strcmp(argv[1], "--check") == 0));
 	argv++;
 	argc--;
 
