Comment fixes.

robertmhaas · robertmhaas · commit e1a6375d8f3a · 2012-08-30T10:42:28.000-04:00
Jeff Davis, somewhat edited by me
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8784,9 +8784,10 @@ copy_relation_data(SMgrRelation src, SMgrRelation dst,
 	pfree(buf);
 
 	/*
-	 * If the rel isn't temp, we must fsync it down to disk before it's safe
-	 * to commit the transaction.  (For a temp rel we don't care since the rel
-	 * will be uninteresting after a crash anyway.)
+	 * If the rel is WAL-logged, must fsync before commit.	We use heap_sync
+	 * to ensure that the toast table gets fsync'd too.  (For a temp or
+	 * unlogged rel we don't care since the data will be gone after a crash
+	 * anyway.)
 	 *
 	 * It's obvious that we must do this when not WAL-logging the copy. It's
 	 * less obvious that we have to do it even if we did WAL-log the copied
diff --git a/src/backend/storage/file/reinit.c b/src/backend/storage/file/reinit.c
@@ -337,7 +337,6 @@ ResetUnloggedRelationsInDbspaceDir(const char *dbspacedirname, int op)
 			copy_file(srcpath, dstpath);
 		}
 
-		/* Done with the first pass. */
 		FreeDir(dbspace_dir);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,6 @@ ResetUnloggedRelationsInDbspaceDir(const char *dbspacedirname, int op)`
`337`	`337`	`copy_file(srcpath, dstpath);`
`338`	`338`	`}`
`339`	`339`
`340`		`- /* Done with the first pass. */`
`341`	`340`	`FreeDir(dbspace_dir);`
`342`	`341`	`}`
`343`	`342`	`}`