Add missing bad-PGconn guards in libpq entry points.

tglsfdc · tglsfdc · commit e37e9a655175 · 2022-08-15T15:40:07.000-04:00
There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL; while it's not clear that ordinary usage could reach that with a null conn pointer, it's cheap enough to check, so let's be consistent. Daniele Varrazzo and Tom Lane Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
@@ -3267,6 +3267,8 @@ PQsetnonblocking(PGconn *conn, int arg)
 int
 PQisnonblocking(const PGconn *conn)
 {
+	if (!conn || conn->status == CONNECTION_BAD)
+		return false;
 	return pqIsnonblocking(conn);
 }
 
@@ -3286,6 +3288,8 @@ PQisthreadsafe(void)
 int
 PQflush(PGconn *conn)
 {
+	if (!conn || conn->status == CONNECTION_BAD)
+		return -1;
 	return pqFlush(conn);
 }
 
diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c
@@ -1747,7 +1747,7 @@ my_SSL_set_fd(PGconn *conn, int fd)
 int
 PQdefaultSSLKeyPassHook_OpenSSL(char *buf, int size, PGconn *conn)
 {
-	if (conn->sslpassword)
+	if (conn && conn->sslpassword)
 	{
 		if (strlen(conn->sslpassword) + 1 > size)
 			fprintf(stderr, libpq_gettext("WARNING: sslpassword truncated\n"));

Original file line number	Diff line number	Diff line change
`@@ -3267,6 +3267,8 @@ PQsetnonblocking(PGconn *conn, int arg)`
`3267`	`3267`	`int`
`3268`	`3268`	`PQisnonblocking(const PGconn *conn)`
`3269`	`3269`	`{`
	`3270`	`+ if (!conn \|\| conn->status == CONNECTION_BAD)`
	`3271`	`+ return false;`
`3270`	`3272`	`return pqIsnonblocking(conn);`
`3271`	`3273`	`}`
`3272`	`3274`
`@@ -3286,6 +3288,8 @@ PQisthreadsafe(void)`
`3286`	`3288`	`int`
`3287`	`3289`	`PQflush(PGconn *conn)`
`3288`	`3290`	`{`
	`3291`	`+ if (!conn \|\| conn->status == CONNECTION_BAD)`
	`3292`	`+ return -1;`
`3289`	`3293`	`return pqFlush(conn);`
`3290`	`3294`	`}`
`3291`	`3295`
Original file line number	Diff line number	Diff line change
`@@ -1747,7 +1747,7 @@ my_SSL_set_fd(PGconn *conn, int fd)`
`1747`	`1747`	`int`
`1748`	`1748`	`PQdefaultSSLKeyPassHook_OpenSSL(char buf, int size, PGconn conn)`
`1749`	`1749`	`{`
`1750`		`- if (conn->sslpassword)`
	`1750`	`+ if (conn && conn->sslpassword)`
`1751`	`1751`	`{`
`1752`	`1752`	`if (strlen(conn->sslpassword) + 1 > size)`
`1753`	`1753`	`fprintf(stderr, libpq_gettext("WARNING: sslpassword truncated\n"));`