Use fabsf() instead of Abs() or fabs() where appropriate

petere · petere · commit e4c61bedcb79 · 2022-10-08T13:43:26.000+02:00
This function is new in C99. Reviewed-by: Zhang Mingli <zmlpostgres@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/4beb42b5-216b-bce8-d452-d924d5794c63%40enterprisedb.com
diff --git a/contrib/btree_gist/btree_float4.c b/contrib/btree_gist/btree_float4.c
@@ -102,7 +102,7 @@ float4_dist(PG_FUNCTION_ARGS)
 	if (unlikely(isinf(r)) && !isinf(a) && !isinf(b))
 		float_overflow_error();
 
-	PG_RETURN_FLOAT4(Abs(r));
+	PG_RETURN_FLOAT4(fabsf(r));
 }
 
 
diff --git a/contrib/intarray/_int_gist.c b/contrib/intarray/_int_gist.c
@@ -540,7 +540,7 @@ g_int_picksplit(PG_FUNCTION_ARGS)
 		union_d = inner_int_union(datum_r, datum_alpha);
 		rt__int_size(union_d, &size_beta);
 		pfree(union_d);
-		costvector[i - 1].cost = fabs((size_alpha - size_l) - (size_beta - size_r));
+		costvector[i - 1].cost = fabsf((size_alpha - size_l) - (size_beta - size_r));
 	}
 	qsort((void *) costvector, maxoff, sizeof(SPLITCOST), comparecost);
 
diff --git a/contrib/seg/seg.c b/contrib/seg/seg.c
@@ -10,6 +10,7 @@
 #include "postgres.h"
 
 #include <float.h>
+#include <math.h>
 
 #include "access/gist.h"
 #include "access/stratnum.h"
@@ -706,15 +707,15 @@ rt_seg_size(SEG *a, float *size)
 	if (a == (SEG *) NULL || a->upper <= a->lower)
 		*size = 0.0;
 	else
-		*size = (float) Abs(a->upper - a->lower);
+		*size = fabsf(a->upper - a->lower);
 }
 
 Datum
 seg_size(PG_FUNCTION_ARGS)
 {
 	SEG		   *seg = PG_GETARG_SEG_P(0);
 
-	PG_RETURN_FLOAT4((float) Abs(seg->upper - seg->lower));
+	PG_RETURN_FLOAT4(fabsf(seg->upper - seg->lower));
 }
 
 
diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
@@ -593,7 +593,7 @@ float4abs(PG_FUNCTION_ARGS)
 {
 	float4		arg1 = PG_GETARG_FLOAT4(0);
 
-	PG_RETURN_FLOAT4((float4) fabs(arg1));
+	PG_RETURN_FLOAT4(fabsf(arg1));
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ float4_dist(PG_FUNCTION_ARGS)`
`102`	`102`	`if (unlikely(isinf(r)) && !isinf(a) && !isinf(b))`
`103`	`103`	`float_overflow_error();`
`104`	`104`
`105`		`- PG_RETURN_FLOAT4(Abs(r));`
	`105`	`+ PG_RETURN_FLOAT4(fabsf(r));`
`106`	`106`	`}`
`107`	`107`
`108`	`108`
Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ g_int_picksplit(PG_FUNCTION_ARGS)`
`540`	`540`	`union_d = inner_int_union(datum_r, datum_alpha);`
`541`	`541`	`rt__int_size(union_d, &size_beta);`
`542`	`542`	`pfree(union_d);`
`543`		`- costvector[i - 1].cost = fabs((size_alpha - size_l) - (size_beta - size_r));`
	`543`	`+ costvector[i - 1].cost = fabsf((size_alpha - size_l) - (size_beta - size_r));`
`544`	`544`	`}`
`545`	`545`	`qsort((void *) costvector, maxoff, sizeof(SPLITCOST), comparecost);`
`546`	`546`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`#include "postgres.h"`
`11`	`11`
`12`	`12`	`#include <float.h>`
	`13`	`+#include <math.h>`
`13`	`14`
`14`	`15`	`#include "access/gist.h"`
`15`	`16`	`#include "access/stratnum.h"`
`@@ -706,15 +707,15 @@ rt_seg_size(SEG a, float size)`
`706`	`707`	`if (a == (SEG *) NULL \|\| a->upper <= a->lower)`
`707`	`708`	`*size = 0.0;`
`708`	`709`	`else`
`709`		`- *size = (float) Abs(a->upper - a->lower);`
	`710`	`+ *size = fabsf(a->upper - a->lower);`
`710`	`711`	`}`
`711`	`712`
`712`	`713`	`Datum`
`713`	`714`	`seg_size(PG_FUNCTION_ARGS)`
`714`	`715`	`{`
`715`	`716`	`SEG *seg = PG_GETARG_SEG_P(0);`
`716`	`717`
`717`		`- PG_RETURN_FLOAT4((float) Abs(seg->upper - seg->lower));`
	`718`	`+ PG_RETURN_FLOAT4(fabsf(seg->upper - seg->lower));`
`718`	`719`	`}`
`719`	`720`
`720`	`721`
Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,7 @@ float4abs(PG_FUNCTION_ARGS)`
`593`	`593`	`{`
`594`	`594`	`float4 arg1 = PG_GETARG_FLOAT4(0);`
`595`	`595`
`596`		`- PG_RETURN_FLOAT4((float4) fabs(arg1));`
	`596`	`+ PG_RETURN_FLOAT4(fabsf(arg1));`
`597`	`597`	`}`
`598`	`598`
`599`	`599`	`/*`