Fix nasty memory leak in pg_restore: _PrintData called inflateInit but

tglsfdc · tglsfdc · commit e7257b8eb213 · 2001-11-27T23:48:12.000Z
never did inflateEnd, thus leaking some tens of KB per call.  Which
added up *real fast* when dealing with, say, thousands of BLOBs.
Thanks to Lane Rollins for the bug report.
diff --git a/src/bin/pg_dump/pg_backup_custom.c b/src/bin/pg_dump/pg_backup_custom.c
@@ -19,7 +19,7 @@
  *
  *
  * IDENTIFICATION
- *		$Header: /cvsroot/pgsql/src/bin/pg_dump/pg_backup_custom.c,v 1.16 2001/10/25 05:49:52 momjian Exp $
+ *		$Header: /cvsroot/pgsql/src/bin/pg_dump/pg_backup_custom.c,v 1.17 2001/11/27 23:48:12 tgl Exp $
  *
  * Modifications - 28-Jun-2000 - pjw@rhyme.com.au
  *
@@ -622,6 +622,8 @@ _PrintData(ArchiveHandle *AH)
 			out[zlibOutSize - zp->avail_out] = '\0';
 			ahwrite(out, 1, zlibOutSize - zp->avail_out, AH);
 		}
+		if (inflateEnd(zp) != Z_OK)
+			die_horribly(AH, modulename, "could not close compression library: %s\n", zp->msg);
 	}
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*`
`20`	`20`	`*`
`21`	`21`	`* IDENTIFICATION`
`22`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_backup_custom.c,v 1.16 2001/10/25 05:49:52 momjian Exp $`
	`22`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_backup_custom.c,v 1.17 2001/11/27 23:48:12 tgl Exp $`
`23`	`23`	`*`
`24`	`24`	`* Modifications - 28-Jun-2000 - pjw@rhyme.com.au`
`25`	`25`	`*`
`@@ -622,6 +622,8 @@ _PrintData(ArchiveHandle *AH)`
`622`	`622`	`out[zlibOutSize - zp->avail_out] = '\0';`
`623`	`623`	`ahwrite(out, 1, zlibOutSize - zp->avail_out, AH);`
`624`	`624`	`}`
	`625`	`+ if (inflateEnd(zp) != Z_OK)`
	`626`	`+ die_horribly(AH, modulename, "could not close compression library: %s\n", zp->msg);`
`625`	`627`	`}`
`626`	`628`	`#endif`
`627`	`629`