Fix handling of multi-column BRIN indexes

tvondra · tvondra · commit e72910f80801 · 2023-02-19T01:46:58.000+01:00
When evaluating clauses on multiple scan keys of a multi-column BRIN index, we can stop processing as soon as we find a scan key eliminating the range, and the range should not be added to tbe bitmap. That's how it worked before 14, but since a681e3c the code treated the range as matching if it matched at least the last scan key. Backpatch to 14, where this code was introduced. Backpatch-through: 14 Discussion: https://postgr.es/m/ebc18613-125e-60df-7520-fcbe0f9274fc%40enterprisedb.com
diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
@@ -686,6 +686,13 @@ bringetbitmap(IndexScanDesc scan, TIDBitmap *tbm)
 								break;
 						}
 					}
+
+					/*
+					 * If we found a scan key eliminating the range, no need to
+					 * check additional ones.
+					 */
+					if (!addrange)
+						break;
 				}
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -686,6 +686,13 @@ bringetbitmap(IndexScanDesc scan, TIDBitmap *tbm)`
`686`	`686`	`break;`
`687`	`687`	`}`
`688`	`688`	`}`
	`689`	`+`
	`690`	`+ /*`
	`691`	`+ * If we found a scan key eliminating the range, no need to`
	`692`	`+ * check additional ones.`
	`693`	`+ */`
	`694`	`+ if (!addrange)`
	`695`	`+ break;`
`689`	`696`	`}`
`690`	`697`	`}`
`691`	`698`	`}`