Fix OID passed to object-alter hook during ALTER CONSTRAINT

alvherre · alvherre · commit e798d095da3a · 2021-05-04T10:09:12.000-04:00
The OID of the constraint is used instead of the OID of the trigger -- an easy mistake to make. Apparently the object-alter hooks are not very well tested :-( Backpatch to 12, where this typo was introduced by 578b229 Discussion: https://postgr.es/m/20210503231633.GA6994@alvherre.pgsql
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -10319,7 +10319,7 @@ ATExecAlterConstraint(Relation rel, AlterTableCmd *cmd,
 			copy_tg->tginitdeferred = cmdcon->initdeferred;
 			CatalogTupleUpdate(tgrel, &copyTuple->t_self, copyTuple);
 
-			InvokeObjectPostAlterHook(TriggerRelationId, currcon->oid, 0);
+			InvokeObjectPostAlterHook(TriggerRelationId, tgform->oid, 0);
 
 			heap_freetuple(copyTuple);
 		}

Original file line number	Diff line number	Diff line change
`@@ -10319,7 +10319,7 @@ ATExecAlterConstraint(Relation rel, AlterTableCmd *cmd,`
`10319`	`10319`	`copy_tg->tginitdeferred = cmdcon->initdeferred;`
`10320`	`10320`	`CatalogTupleUpdate(tgrel, &copyTuple->t_self, copyTuple);`
`10321`	`10321`
`10322`		`- InvokeObjectPostAlterHook(TriggerRelationId, currcon->oid, 0);`
	`10322`	`+ InvokeObjectPostAlterHook(TriggerRelationId, tgform->oid, 0);`
`10323`	`10323`
`10324`	`10324`	`heap_freetuple(copyTuple);`
`10325`	`10325`	`}`