This is a stupid garden variety bug and I'm not sure why I didn't catch

bmomjian · bmomjian · commit e7b069ced164 · 2000-10-10T17:13:30.000Z
it previously.  The patch included is against fairly current sources, but
it may apply cleanly against 7.0.2 as well.

On Fri, 6 Oct 2000, Vilson farias wrote:

&gt; I found a irregular behavior with constraints.
&gt;
&gt; I can only set a referencial integrity between these tables when there are
&gt; no data, even if there are no change to referential integrity violation.
diff --git a/src/backend/commands/command.c b/src/backend/commands/command.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.105 2000/10/05 19:48:22 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.106 2000/10/10 17:13:30 momjian Exp $
  *
  * NOTES
  *	  The PerformAddAttribute() code, like most of the relation
@@ -1389,15 +1389,18 @@ AlterTableAddConstraint(char *relationName,
 				{
 					Ident	   *fk_at = lfirst(list);
 
-					trig.tgargs[count++] = fk_at->name;
+					trig.tgargs[count] = fk_at->name;
+					count+=2;
 				}
+			count = 5;
 			foreach(list, fkconstraint->pk_attrs)
 				{
 					Ident	   *pk_at = lfirst(list);
 
-					trig.tgargs[count++] = pk_at->name;
+					trig.tgargs[count] = pk_at->name;
+					count+=2;
 				}
-			trig.tgnargs = count;
+			trig.tgnargs = count-1;
 
 			scan = heap_beginscan(rel, false, SnapshotNow, 0, NULL);
 			AssertState(scan != NULL);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.105 2000/10/05 19:48:22 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/command.c,v 1.106 2000/10/10 17:13:30 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* The PerformAddAttribute() code, like most of the relation`
`@@ -1389,15 +1389,18 @@ AlterTableAddConstraint(char *relationName,`
`1389`	`1389`	`{`
`1390`	`1390`	`Ident *fk_at = lfirst(list);`
`1391`	`1391`
`1392`		`- trig.tgargs[count++] = fk_at->name;`
	`1392`	`+ trig.tgargs[count] = fk_at->name;`
	`1393`	`+ count+=2;`
`1393`	`1394`	`}`
	`1395`	`+ count = 5;`
`1394`	`1396`	`foreach(list, fkconstraint->pk_attrs)`
`1395`	`1397`	`{`
`1396`	`1398`	`Ident *pk_at = lfirst(list);`
`1397`	`1399`
`1398`		`- trig.tgargs[count++] = pk_at->name;`
	`1400`	`+ trig.tgargs[count] = pk_at->name;`
	`1401`	`+ count+=2;`
`1399`	`1402`	`}`
`1400`		`- trig.tgnargs = count;`
	`1403`	`+ trig.tgnargs = count-1;`
`1401`	`1404`
`1402`	`1405`	`scan = heap_beginscan(rel, false, SnapshotNow, 0, NULL);`
`1403`	`1406`	`AssertState(scan != NULL);`