Add UtilityReturnsTuples() support for CALL

petere · petere · commit ec67b8981601 · 2018-07-09T13:58:08.000+02:00
This ensures that prepared statements for CALL can return tuples.
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
@@ -51,6 +51,7 @@
 #include "commands/proclang.h"
 #include "executor/execdesc.h"
 #include "executor/executor.h"
+#include "funcapi.h"
 #include "miscadmin.h"
 #include "optimizer/clauses.h"
 #include "optimizer/var.h"
@@ -2340,3 +2341,26 @@ ExecuteCallStmt(CallStmt *stmt, ParamListInfo params, bool atomic, DestReceiver
 
 	FreeExecutorState(estate);
 }
+
+/*
+ * Construct the tuple descriptor for a CALL statement return
+ */
+TupleDesc
+CallStmtResultDesc(CallStmt *stmt)
+{
+	FuncExpr   *fexpr;
+	HeapTuple   tuple;
+	TupleDesc   tupdesc;
+
+	fexpr = stmt->funcexpr;
+
+	tuple = SearchSysCache1(PROCOID, ObjectIdGetDatum(fexpr->funcid));
+	if (!HeapTupleIsValid(tuple))
+		elog(ERROR, "cache lookup failed for procedure %u", fexpr->funcid);
+
+	tupdesc = build_function_result_tupdesc_t(tuple);
+
+	ReleaseSysCache(tuple);
+
+	return tupdesc;
+}
diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
@@ -1744,6 +1744,12 @@ UtilityReturnsTuples(Node *parsetree)
 {
 	switch (nodeTag(parsetree))
 	{
+		case T_CallStmt:
+			{
+				CallStmt   *stmt = (CallStmt *) parsetree;
+
+				return (stmt->funcexpr->funcresulttype == RECORDOID);
+			}
 		case T_FetchStmt:
 			{
 				FetchStmt  *stmt = (FetchStmt *) parsetree;
@@ -1794,6 +1800,9 @@ UtilityTupleDescriptor(Node *parsetree)
 {
 	switch (nodeTag(parsetree))
 	{
+		case T_CallStmt:
+			return CallStmtResultDesc((CallStmt *) parsetree);
+
 		case T_FetchStmt:
 			{
 				FetchStmt  *stmt = (FetchStmt *) parsetree;
diff --git a/src/include/commands/defrem.h b/src/include/commands/defrem.h
@@ -64,6 +64,7 @@ extern void IsThereFunctionInNamespace(const char *proname, int pronargs,
 						   oidvector *proargtypes, Oid nspOid);
 extern void ExecuteDoStmt(DoStmt *stmt, bool atomic);
 extern void ExecuteCallStmt(CallStmt *stmt, ParamListInfo params, bool atomic, DestReceiver *dest);
+extern TupleDesc CallStmtResultDesc(CallStmt *stmt);
 extern Oid	get_cast_oid(Oid sourcetypeid, Oid targettypeid, bool missing_ok);
 extern Oid	get_transform_oid(Oid type_id, Oid lang_id, bool missing_ok);
 extern void interpret_function_parameter_list(ParseState *pstate,

Original file line number	Diff line number	Diff line change
`@@ -1744,6 +1744,12 @@ UtilityReturnsTuples(Node *parsetree)`
`1744`	`1744`	`{`
`1745`	`1745`	`switch (nodeTag(parsetree))`
`1746`	`1746`	`{`
	`1747`	`+ case T_CallStmt:`
	`1748`	`+ {`
	`1749`	`+ CallStmt stmt = (CallStmt ) parsetree;`
	`1750`	`+`
	`1751`	`+ return (stmt->funcexpr->funcresulttype == RECORDOID);`
	`1752`	`+ }`
`1747`	`1753`	`case T_FetchStmt:`
`1748`	`1754`	`{`
`1749`	`1755`	`FetchStmt stmt = (FetchStmt ) parsetree;`
`@@ -1794,6 +1800,9 @@ UtilityTupleDescriptor(Node *parsetree)`
`1794`	`1800`	`{`
`1795`	`1801`	`switch (nodeTag(parsetree))`
`1796`	`1802`	`{`
	`1803`	`+ case T_CallStmt:`
	`1804`	`+ return CallStmtResultDesc((CallStmt *) parsetree);`
	`1805`	`+`
`1797`	`1806`	`case T_FetchStmt:`
`1798`	`1807`	`{`
`1799`	`1808`	`FetchStmt stmt = (FetchStmt ) parsetree;`