Done:

bmomjian · bmomjian · commit ec9d01e8e2d9 · 2006-04-24T22:56:11.000Z
o -Add support for day-time syntax, INTERVAL '1 2:03:04' DAY TO
        SECOND
diff --git a/doc/TODO b/doc/TODO
@@ -225,7 +225,6 @@ Data Types
 	  computations should adjust based on the time zone rules.
 
 	o Fix SELECT '0.01 years'::interval, '0.01 months'::interval
-	o Fix SELECT INTERVAL '1' MONTH
 	o Add a GUC variable to allow output of interval values in ISO8601 
 	  format
 	o Improve timestamptz subtraction to be DST-aware
@@ -240,8 +239,9 @@ Data Types
 	o Fix interval display to support values exceeding 2^31 hours
 	o Add overflow checking to timestamp and interval arithmetic	
 	o Add ISO INTERVAL handling
-		o Add support for day-time syntax, INTERVAL '1 2:03:04' DAY TO 
+		o -Add support for day-time syntax, INTERVAL '1 2:03:04' DAY TO 
 		  SECOND
+		o Fix SELECT INTERVAL '1' MONTH
 		o Add support for year-month syntax, INTERVAL '50-6' YEAR TO MONTH
 		o For syntax that isn't uniquely ISO or PG syntax, like '1:30' or
 		  '1', treat as ISO if there is a range specification clause,
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.538 2006/04/15 17:45:34 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.539 2006/04/24 22:56:11 momjian Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -1152,6 +1152,7 @@ zone_value:
 					A_Const *n = (A_Const *) makeStringConst($2, $1);
 					if ($3 != INTERVAL_FULL_RANGE)
 					{
+						ereport(LOG, (errmsg("1.0")));
 						if (($3 & ~(INTERVAL_MASK(HOUR) | INTERVAL_MASK(MINUTE))) != 0)
 							ereport(ERROR,
 									(errcode(ERRCODE_SYNTAX_ERROR),
@@ -1163,6 +1164,7 @@ zone_value:
 			| ConstInterval '(' Iconst ')' Sconst opt_interval
 				{
 					A_Const *n = (A_Const *) makeStringConst($5, $1);
+						ereport(LOG, (errmsg("2.0")));
 					if ($3 < 0)
 						ereport(ERROR,
 								(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
@@ -6078,12 +6080,14 @@ SimpleTypename:
 			| ConstDatetime							{ $$ = $1; }
 			| ConstInterval opt_interval
 				{
+						ereport(LOG, (errmsg("3.0")));
 					$$ = $1;
 					if ($2 != INTERVAL_FULL_RANGE)
 						$$->typmod = INTERVAL_TYPMOD(INTERVAL_FULL_PRECISION, $2);
 				}
 			| ConstInterval '(' Iconst ')' opt_interval
 				{
+						ereport(LOG, (errmsg("4.0")));
 					$$ = $1;
 					if ($3 < 0)
 						ereport(ERROR,
@@ -6102,6 +6106,7 @@ SimpleTypename:
 				}
 			| type_name attrs
 				{
+						ereport(LOG, (errmsg("5.0")));
 					$$ = makeNode(TypeName);
 					$$->names = lcons(makeString($1), $2);
 					$$->typmod = -1;
@@ -8179,6 +8184,7 @@ AexprConst: Iconst
 			| ConstInterval Sconst opt_interval
 				{
 					A_Const *n = makeNode(A_Const);
+						ereport(LOG, (errmsg("6.0")));
 					n->typename = $1;
 					n->val.type = T_String;
 					n->val.val.str = $2;
@@ -8190,6 +8196,7 @@ AexprConst: Iconst
 			| ConstInterval '(' Iconst ')' Sconst opt_interval
 				{
 					A_Const *n = makeNode(A_Const);
+						ereport(LOG, (errmsg("7.0")));
 					n->typename = $1;
 					n->val.type = T_String;
 					n->val.val.str = $5;

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.538 2006/04/15 17:45:34 tgl Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.539 2006/04/24 22:56:11 momjian Exp $`
`15`	`15`	`*`
`16`	`16`	`* HISTORY`
`17`	`17`	`* AUTHOR DATE MAJOR EVENT`
`@@ -1152,6 +1152,7 @@ zone_value:`
`1152`	`1152`	`A_Const n = (A_Const ) makeStringConst($2, $1);`
`1153`	`1153`	`if ($3 != INTERVAL_FULL_RANGE)`
`1154`	`1154`	`{`
	`1155`	`+ ereport(LOG, (errmsg("1.0")));`
`1155`	`1156`	`if (($3 & ~(INTERVAL_MASK(HOUR) \| INTERVAL_MASK(MINUTE))) != 0)`
`1156`	`1157`	`ereport(ERROR,`
`1157`	`1158`	`(errcode(ERRCODE_SYNTAX_ERROR),`
`@@ -1163,6 +1164,7 @@ zone_value:`
`1163`	`1164`	`\| ConstInterval '(' Iconst ')' Sconst opt_interval`
`1164`	`1165`	`{`
`1165`	`1166`	`A_Const n = (A_Const ) makeStringConst($5, $1);`
	`1167`	`+ ereport(LOG, (errmsg("2.0")));`
`1166`	`1168`	`if ($3 < 0)`
`1167`	`1169`	`ereport(ERROR,`
`1168`	`1170`	`(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
`@@ -6078,12 +6080,14 @@ SimpleTypename:`
`6078`	`6080`	`\| ConstDatetime { $$ = $1; }`
`6079`	`6081`	`\| ConstInterval opt_interval`
`6080`	`6082`	`{`
	`6083`	`+ ereport(LOG, (errmsg("3.0")));`
`6081`	`6084`	`$$ = $1;`
`6082`	`6085`	`if ($2 != INTERVAL_FULL_RANGE)`
`6083`	`6086`	`$$->typmod = INTERVAL_TYPMOD(INTERVAL_FULL_PRECISION, $2);`
`6084`	`6087`	`}`
`6085`	`6088`	`\| ConstInterval '(' Iconst ')' opt_interval`
`6086`	`6089`	`{`
	`6090`	`+ ereport(LOG, (errmsg("4.0")));`
`6087`	`6091`	`$$ = $1;`
`6088`	`6092`	`if ($3 < 0)`
`6089`	`6093`	`ereport(ERROR,`
`@@ -6102,6 +6106,7 @@ SimpleTypename:`
`6102`	`6106`	`}`
`6103`	`6107`	`\| type_name attrs`
`6104`	`6108`	`{`
	`6109`	`+ ereport(LOG, (errmsg("5.0")));`
`6105`	`6110`	`$$ = makeNode(TypeName);`
`6106`	`6111`	`$$->names = lcons(makeString($1), $2);`
`6107`	`6112`	`$$->typmod = -1;`
`@@ -8179,6 +8184,7 @@ AexprConst: Iconst`
`8179`	`8184`	`\| ConstInterval Sconst opt_interval`
`8180`	`8185`	`{`
`8181`	`8186`	`A_Const *n = makeNode(A_Const);`
	`8187`	`+ ereport(LOG, (errmsg("6.0")));`
`8182`	`8188`	`n->typename = $1;`
`8183`	`8189`	`n->val.type = T_String;`
`8184`	`8190`	`n->val.val.str = $2;`
`@@ -8190,6 +8196,7 @@ AexprConst: Iconst`
`8190`	`8196`	`\| ConstInterval '(' Iconst ')' Sconst opt_interval`
`8191`	`8197`	`{`
`8192`	`8198`	`A_Const *n = makeNode(A_Const);`
	`8199`	`+ ereport(LOG, (errmsg("7.0")));`
`8193`	`8200`	`n->typename = $1;`
`8194`	`8201`	`n->val.type = T_String;`
`8195`	`8202`	`n->val.val.str = $5;`