Fix resource leak pointed out by Coverity.

tatsuo-ishii · tatsuo-ishii · commit ed0e03283579 · 2014-12-30T20:20:56.000+09:00
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -1745,6 +1745,7 @@ parseQuery(Command *cmd, const char *raw_sql)
 		if (cmd->argc >= MAX_ARGS)
 		{
 			fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);
+			pg_free(name);
 			return false;
 		}
 
@@ -1942,6 +1943,7 @@ process_file(char *filename)
 	else if ((fd = fopen(filename, "r")) == NULL)
 	{
 		fprintf(stderr, "%s: %s\n", filename, strerror(errno));
+		pg_free(my_commands);
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1745,6 +1745,7 @@ parseQuery(Command cmd, const char raw_sql)`
`1745`	`1745`	`if (cmd->argc >= MAX_ARGS)`
`1746`	`1746`	`{`
`1747`	`1747`	`fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);`
	`1748`	`+ pg_free(name);`
`1748`	`1749`	`return false;`
`1749`	`1750`	`}`
`1750`	`1751`
`@@ -1942,6 +1943,7 @@ process_file(char *filename)`
`1942`	`1943`	`else if ((fd = fopen(filename, "r")) == NULL)`
`1943`	`1944`	`{`
`1944`	`1945`	`fprintf(stderr, "%s: %s\n", filename, strerror(errno));`
	`1946`	`+ pg_free(my_commands);`
`1945`	`1947`	`return false;`
`1946`	`1948`	`}`
`1947`	`1949`