Skip to content

Commit ed5e5f0

Browse files
peterepetere
committed
Remove unnecessary (char *) casts [xlog]
Remove (char *) casts no longer needed after XLogRegisterData() and XLogRegisterBufData() argument type change. Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
1 parent cdaeff9 commit ed5e5f0

39 files changed

+232
-232
lines changed

‎contrib/pg_visibility/pg_visibility.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ pg_truncate_visibility_map(PG_FUNCTION_ARGS)
424424
xlrec.flags = SMGR_TRUNCATE_VM;
425425

426426
XLogBeginInsert();
427-
XLogRegisterData((char *) &xlrec, sizeof(xlrec));
427+
XLogRegisterData(&xlrec, sizeof(xlrec));
428428

429429
lsn = XLogInsert(RM_SMGR_ID,
430430
XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE);

‎src/backend/access/brin/brin.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1135,7 +1135,7 @@ brinbuild(Relation heap, Relation index, IndexInfo *indexInfo)
11351135
xlrec.pagesPerRange = BrinGetPagesPerRange(index);
11361136

11371137
XLogBeginInsert();
1138-
XLogRegisterData((char *) &xlrec, SizeOfBrinCreateIdx);
1138+
XLogRegisterData(&xlrec, SizeOfBrinCreateIdx);
11391139
XLogRegisterBuffer(0, meta, REGBUF_WILL_INIT | REGBUF_STANDARD);
11401140

11411141
recptr = XLogInsert(RM_BRIN_ID, XLOG_BRIN_CREATE_INDEX);

‎src/backend/access/brin/brin_pageops.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,10 @@ brin_doupdate(Relation idxrel, BlockNumber pagesPerRange,
190190
xlrec.offnum = oldoff;
191191

192192
XLogBeginInsert();
193-
XLogRegisterData((char *) &xlrec, SizeOfBrinSamepageUpdate);
193+
XLogRegisterData(&xlrec, SizeOfBrinSamepageUpdate);
194194

195195
XLogRegisterBuffer(0, oldbuf, REGBUF_STANDARD);
196-
XLogRegisterBufData(0, (const char *) newtup, newsz);
196+
XLogRegisterBufData(0, newtup, newsz);
197197

198198
recptr = XLogInsert(RM_BRIN_ID, info);
199199

@@ -282,10 +282,10 @@ brin_doupdate(Relation idxrel, BlockNumber pagesPerRange,
282282
XLogBeginInsert();
283283

284284
/* new page */
285-
XLogRegisterData((char *) &xlrec, SizeOfBrinUpdate);
285+
XLogRegisterData(&xlrec, SizeOfBrinUpdate);
286286

287287
XLogRegisterBuffer(0, newbuf, REGBUF_STANDARD | (extended ? REGBUF_WILL_INIT : 0));
288-
XLogRegisterBufData(0, (const char *) newtup, newsz);
288+
XLogRegisterBufData(0, newtup, newsz);
289289

290290
/* revmap page */
291291
XLogRegisterBuffer(1, revmapbuf, 0);
@@ -435,10 +435,10 @@ brin_doinsert(Relation idxrel, BlockNumber pagesPerRange,
435435
xlrec.offnum = off;
436436

437437
XLogBeginInsert();
438-
XLogRegisterData((char *) &xlrec, SizeOfBrinInsert);
438+
XLogRegisterData(&xlrec, SizeOfBrinInsert);
439439

440440
XLogRegisterBuffer(0, *buffer, REGBUF_STANDARD | (extended ? REGBUF_WILL_INIT : 0));
441-
XLogRegisterBufData(0, (char *) tup, itemsz);
441+
XLogRegisterBufData(0, tup, itemsz);
442442

443443
XLogRegisterBuffer(1, revmapbuf, 0);
444444

‎src/backend/access/brin/brin_revmap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ brinRevmapDesummarizeRange(Relation idxrel, BlockNumber heapBlk)
416416
xlrec.regOffset = regOffset;
417417

418418
XLogBeginInsert();
419-
XLogRegisterData((char *) &xlrec, SizeOfBrinDesummarize);
419+
XLogRegisterData(&xlrec, SizeOfBrinDesummarize);
420420
XLogRegisterBuffer(0, revmapBuf, 0);
421421
XLogRegisterBuffer(1, regBuf, REGBUF_STANDARD);
422422
recptr = XLogInsert(RM_BRIN_ID, XLOG_BRIN_DESUMMARIZE);
@@ -627,7 +627,7 @@ revmap_physical_extend(BrinRevmap *revmap)
627627
xlrec.targetBlk = mapBlk;
628628

629629
XLogBeginInsert();
630-
XLogRegisterData((char *) &xlrec, SizeOfBrinRevmapExtend);
630+
XLogRegisterData(&xlrec, SizeOfBrinRevmapExtend);
631631
XLogRegisterBuffer(0, revmap->rm_metaBuf, REGBUF_STANDARD);
632632

633633
XLogRegisterBuffer(1, buf, REGBUF_WILL_INIT);

‎src/backend/access/gin/ginbtree.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
423423

424424
xlrec.flags = xlflags;
425425

426-
XLogRegisterData((char *) &xlrec, sizeof(ginxlogInsert));
426+
XLogRegisterData(&xlrec, sizeof(ginxlogInsert));
427427

428428
/*
429429
* Log information about child if this was an insertion of a
@@ -433,7 +433,7 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
433433
{
434434
BlockIdSet(&childblknos[0], BufferGetBlockNumber(childbuf));
435435
BlockIdSet(&childblknos[1], GinPageGetOpaque(childpage)->rightlink);
436-
XLogRegisterData((char *) childblknos,
436+
XLogRegisterData(childblknos,
437437
sizeof(BlockIdData) * 2);
438438
}
439439

@@ -617,7 +617,7 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
617617
if (BufferIsValid(childbuf))
618618
XLogRegisterBuffer(3, childbuf, REGBUF_STANDARD);
619619

620-
XLogRegisterData((char *) &data, sizeof(ginxlogSplit));
620+
XLogRegisterData(&data, sizeof(ginxlogSplit));
621621

622622
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_SPLIT);
623623

‎src/backend/access/gin/gindatapage.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ typedef struct
6363
* If we need WAL data representing the reconstructed leaf page, it's
6464
* stored here by computeLeafRecompressWALData.
6565
*/
66-
char *walinfo; /* buffer start */
66+
void *walinfo; /* buffer start */
6767
int walinfolen; /* and length */
6868
} disassembledLeaf;
6969

@@ -1173,7 +1173,7 @@ dataExecPlaceToPageInternal(GinBtree btree, Buffer buf, GinBtreeStack *stack,
11731173
data.newitem = *pitem;
11741174

11751175
XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
1176-
XLogRegisterBufData(0, (char *) &data,
1176+
XLogRegisterBufData(0, &data,
11771177
sizeof(ginxlogInsertDataInternal));
11781178
}
11791179
}
@@ -1844,9 +1844,9 @@ createPostingTree(Relation index, ItemPointerData *items, uint32 nitems,
18441844
data.size = rootsize;
18451845

18461846
XLogBeginInsert();
1847-
XLogRegisterData((char *) &data, sizeof(ginxlogCreatePostingTree));
1847+
XLogRegisterData(&data, sizeof(ginxlogCreatePostingTree));
18481848

1849-
XLogRegisterData((char *) GinDataLeafPageGetPostingList(page),
1849+
XLogRegisterData(GinDataLeafPageGetPostingList(page),
18501850
rootsize);
18511851
XLogRegisterBuffer(0, buffer, REGBUF_WILL_INIT);
18521852

‎src/backend/access/gin/ginentrypage.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,9 +585,9 @@ entryExecPlaceToPage(GinBtree btree, Buffer buf, GinBtreeStack *stack,
585585
data.offset = off;
586586

587587
XLogRegisterBuffer(0, buf, REGBUF_STANDARD);
588-
XLogRegisterBufData(0, (char *) &data,
588+
XLogRegisterBufData(0, &data,
589589
offsetof(ginxlogInsertEntry, tuple));
590-
XLogRegisterBufData(0, (char *) insertData->entry,
590+
XLogRegisterBufData(0, insertData->entry,
591591
IndexTupleSize(insertData->entry));
592592
}
593593
}

‎src/backend/access/gin/ginfast.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ writeListPage(Relation index, Buffer buffer,
122122
data.ntuples = ntuples;
123123

124124
XLogBeginInsert();
125-
XLogRegisterData((char *) &data, sizeof(ginxlogInsertListPage));
125+
XLogRegisterData(&data, sizeof(ginxlogInsertListPage));
126126

127127
XLogRegisterBuffer(0, buffer, REGBUF_WILL_INIT);
128128
XLogRegisterBufData(0, workspace.data, size);
@@ -431,7 +431,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
431431
memcpy(&data.metadata, metadata, sizeof(GinMetaPageData));
432432

433433
XLogRegisterBuffer(0, metabuffer, REGBUF_WILL_INIT | REGBUF_STANDARD);
434-
XLogRegisterData((char *) &data, sizeof(ginxlogUpdateMeta));
434+
XLogRegisterData(&data, sizeof(ginxlogUpdateMeta));
435435

436436
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_UPDATE_META_PAGE);
437437
PageSetLSN(metapage, recptr);
@@ -646,7 +646,7 @@ shiftList(Relation index, Buffer metabuffer, BlockNumber newHead,
646646

647647
memcpy(&data.metadata, metadata, sizeof(GinMetaPageData));
648648

649-
XLogRegisterData((char *) &data,
649+
XLogRegisterData(&data,
650650
sizeof(ginxlogDeleteListPages));
651651

652652
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_DELETE_LISTPAGE);

‎src/backend/access/gin/ginutil.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ ginUpdateStats(Relation index, const GinStatsData *stats, bool is_build)
689689
memcpy(&data.metadata, metadata, sizeof(GinMetaPageData));
690690

691691
XLogBeginInsert();
692-
XLogRegisterData((char *) &data, sizeof(ginxlogUpdateMeta));
692+
XLogRegisterData(&data, sizeof(ginxlogUpdateMeta));
693693
XLogRegisterBuffer(0, metabuffer, REGBUF_WILL_INIT | REGBUF_STANDARD);
694694

695695
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_UPDATE_META_PAGE);

‎src/backend/access/gin/ginvacuum.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn
216216
data.rightLink = GinPageGetOpaque(page)->rightlink;
217217
data.deleteXid = GinPageGetDeleteXid(page);
218218

219-
XLogRegisterData((char *) &data, sizeof(ginxlogDeletePage));
219+
XLogRegisterData(&data, sizeof(ginxlogDeletePage));
220220

221221
recptr = XLogInsert(RM_GIN_ID, XLOG_GIN_DELETE_PAGE);
222222
PageSetLSN(page, recptr);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy